Make WER file field names with non-ascii characters usable #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
+ Coverage 76.98% 77.04% +0.05%
==========================================
Files 322 322
Lines 27583 27598 +15
==========================================
+ Hits 21236 21262 +26
+ Misses 6347 6336 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyrco
force-pushed
the
more-robust-wer-field-names
branch
2 times, most recently
from
671eb8c
to
e575221
Compare
|
This PR uncovered a bug in flow.record's field name validation which is fixed in fox-it/flow.record#151 |
cecinestpasunepipe
approved these changes
Nov 11, 2024
We use WER field names as the field names for the records the WER plugin creates. This means they have certain limitations in what characters can be used. Previously all characters in the set [a-zA-Z_] were removed. This patch encodes them as _<utf-8_sequence_in_hex>.
pyrco
force-pushed
the
more-robust-wer-field-names
branch
from
e575221
to
01bda18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use WER field names as the field names for the records the WER plugin creates. This means they have certain limitations in what characters can be used. Previously all characters in the set [a-zA-Z_] were removed. This patch encodes them as _<utf-8_sequence_in_hex>.