-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change linter to Ruff #52
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 86.46% 86.25% -0.22%
==========================================
Files 20 20
Lines 1286 1302 +16
==========================================
+ Hits 1112 1123 +11
- Misses 174 179 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested Ruff for a couple of days and I like it. It is fast, and greatly improves the Developer Experience.
I also agree with the linting configuration.
I do think that more people should review the configuration, and perhaps have a discussion about them. Everyone should be onboard.
Moreover, we need a plan how to to enable this for all projects. I imagine this is quite some work.
Co-authored-by: Miauwkeru <[email protected]>
Initial attempt at using a Ruff-based linting configuration with a number of rules that should apply to the Dissect codebase.
Some that are maybe worth enabling down the line, maybe with some rules ignored or only applied to certain files:
pep8-naming
(N)pydocstyle
(D)flake8-bandit
(S)Reference: https://docs.astral.sh/ruff/rules/