Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

add messages for ROS 2 iron #14

Merged
merged 7 commits into from
Apr 25, 2024
Merged

add messages for ROS 2 iron #14

merged 7 commits into from
Apr 25, 2024

Conversation

achim-k
Copy link
Contributor

@achim-k achim-k commented Apr 23, 2024

Changelog

Add message definitions for ROS2 iron

Description

Adds ROS2 iron messages. See details below for changes wrt. ROS2 humble.

diff -r msgdefs/ros2humble/ msgdefs/ros2iron
diff -r msgdefs/ros2humble/lifecycle_msgs/msg/State.msg msgdefs/ros2iron/lifecycle_msgs/msg/State.msg
17c17
< # This is the main state of the node’s life cycle. While in this state, the node
---
> # This is the main state of the node's life cycle. While in this state, the node
29c29
< # In this transition state the node’s onConfigure callback will be called to
---
> # In this transition state the node's onConfigure callback will be called to
33c33
< # In this transition state the node’s callback onCleanup will be called to clear
---
> # In this transition state the node's callback onCleanup will be called to clear
diff -r msgdefs/ros2humble/lifecycle_msgs/msg/TransitionDescription.msg msgdefs/ros2iron/lifecycle_msgs/msg/TransitionDescription.msg
23c23
< # The node’s onConfigure callback will be called to allow the node to load its
---
> # The node's onConfigure callback will be called to allow the node to load its
27c27
< # The node’s callback onCleanup will be called in this transition to allow the
---
> # The node's callback onCleanup will be called in this transition to allow the
125c125
< # This is the main state of the node’s life cycle. While in this state, the node
---
> # This is the main state of the node's life cycle. While in this state, the node
137c137
< # In this transition state the node’s onConfigure callback will be called to
---
> # In this transition state the node's onConfigure callback will be called to
141c141
< # In this transition state the node’s callback onCleanup will be called to clear
---
> # In this transition state the node's callback onCleanup will be called to clear
185c185
< # This is the main state of the node’s life cycle. While in this state, the node
---
> # This is the main state of the node's life cycle. While in this state, the node
197c197
< # In this transition state the node’s onConfigure callback will be called to
---
> # In this transition state the node's onConfigure callback will be called to
201c201
< # In this transition state the node’s callback onCleanup will be called to clear
---
> # In this transition state the node's callback onCleanup will be called to clear
diff -r msgdefs/ros2humble/lifecycle_msgs/msg/TransitionEvent.msg msgdefs/ros2iron/lifecycle_msgs/msg/TransitionEvent.msg
26c26
< # The node’s onConfigure callback will be called to allow the node to load its
---
> # The node's onConfigure callback will be called to allow the node to load its
30c30
< # The node’s callback onCleanup will be called in this transition to allow the
---
> # The node's callback onCleanup will be called in this transition to allow the
128c128
< # This is the main state of the node’s life cycle. While in this state, the node
---
> # This is the main state of the node's life cycle. While in this state, the node
140c140
< # In this transition state the node’s onConfigure callback will be called to
---
> # In this transition state the node's onConfigure callback will be called to
144c144
< # In this transition state the node’s callback onCleanup will be called to clear
---
> # In this transition state the node's callback onCleanup will be called to clear
188c188
< # This is the main state of the node’s life cycle. While in this state, the node
---
> # This is the main state of the node's life cycle. While in this state, the node
200c200
< # In this transition state the node’s onConfigure callback will be called to
---
> # In this transition state the node's onConfigure callback will be called to
204c204
< # In this transition state the node’s callback onCleanup will be called to clear
---
> # In this transition state the node's callback onCleanup will be called to clear
diff -r msgdefs/ros2humble/lifecycle_msgs/msg/Transition.msg msgdefs/ros2iron/lifecycle_msgs/msg/Transition.msg
12c12
< # The node’s onConfigure callback will be called to allow the node to load its
---
> # The node's onConfigure callback will be called to allow the node to load its
16c16
< # The node’s callback onCleanup will be called in this transition to allow the
---
> # The node's callback onCleanup will be called in this transition to allow the
Only in msgdefs/ros2iron/rcl_interfaces/msg: LoggerLevel.msg
Only in msgdefs/ros2iron/rcl_interfaces/msg: SetLoggerLevelsResult.msg
diff -r msgdefs/ros2humble/sensor_msgs/msg/BatteryState.msg msgdefs/ros2iron/sensor_msgs/msg/BatteryState.msg
26,32c26,34
< uint8 POWER_SUPPLY_TECHNOLOGY_UNKNOWN = 0
< uint8 POWER_SUPPLY_TECHNOLOGY_NIMH = 1
< uint8 POWER_SUPPLY_TECHNOLOGY_LION = 2
< uint8 POWER_SUPPLY_TECHNOLOGY_LIPO = 3
< uint8 POWER_SUPPLY_TECHNOLOGY_LIFE = 4
< uint8 POWER_SUPPLY_TECHNOLOGY_NICD = 5
< uint8 POWER_SUPPLY_TECHNOLOGY_LIMN = 6
---
> uint8 POWER_SUPPLY_TECHNOLOGY_UNKNOWN = 0 # Unknown battery technology
> uint8 POWER_SUPPLY_TECHNOLOGY_NIMH = 1    # Nickel-Metal Hydride battery
> uint8 POWER_SUPPLY_TECHNOLOGY_LION = 2    # Lithium-ion battery
> uint8 POWER_SUPPLY_TECHNOLOGY_LIPO = 3    # Lithium Polymer battery
> uint8 POWER_SUPPLY_TECHNOLOGY_LIFE = 4    # Lithium Iron Phosphate battery
> uint8 POWER_SUPPLY_TECHNOLOGY_NICD = 5    # Nickel-Cadmium battery
> uint8 POWER_SUPPLY_TECHNOLOGY_LIMN = 6    # Lithium Manganese Dioxide battery
> uint8 POWER_SUPPLY_TECHNOLOGY_TERNARY = 7 # Ternary Lithium battery
> uint8 POWER_SUPPLY_TECHNOLOGY_VRLA = 8    # Valve Regulated Lead-Acid battery
diff -r msgdefs/ros2humble/sensor_msgs/msg/Range.msg msgdefs/ros2iron/sensor_msgs/msg/Range.msg
40a41,43
> float32 variance        # variance of the range sensor
>                         # 0 is interpreted as variance unknown
> 
Only in msgdefs/ros2iron/test_msgs/msg: Arrays.msg
Only in msgdefs/ros2iron/test_msgs/msg: BasicTypes.msg
Only in msgdefs/ros2iron/test_msgs/msg: BoundedPlainSequences.msg
Only in msgdefs/ros2iron/test_msgs/msg: BoundedSequences.msg
Only in msgdefs/ros2iron/test_msgs/msg: Constants.msg
Only in msgdefs/ros2iron/test_msgs/msg: Defaults.msg
Only in msgdefs/ros2iron/test_msgs/msg: Empty.msg
Only in msgdefs/ros2iron/test_msgs/msg: MultiNested.msg
Only in msgdefs/ros2iron/test_msgs/msg: Nested.msg
Only in msgdefs/ros2iron/test_msgs/msg: Strings.msg
Only in msgdefs/ros2iron/test_msgs/msg: UnboundedSequences.msg
Only in msgdefs/ros2iron/test_msgs/msg: WStrings.msg
diff -r msgdefs/ros2humble/tf2_msgs/msg/TF2Error.msg msgdefs/ros2iron/tf2_msgs/msg/TF2Error.msg
10a11

@achim-k achim-k force-pushed the achim/ros2-iron-msgs branch from fcf8309 to ce7c836 Compare April 23, 2024 21:48
yarn.lock Show resolved Hide resolved
@achim-k achim-k requested a review from jtbandes April 25, 2024 00:52
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the tests 😄

@achim-k achim-k merged commit c3d941d into main Apr 25, 2024
2 checks passed
@achim-k achim-k deleted the achim/ros2-iron-msgs branch April 25, 2024 17:10
@achim-k achim-k mentioned this pull request Apr 25, 2024
achim-k added a commit that referenced this pull request Apr 25, 2024
Primarily includes #14 and a couple of maintenance PRs
@achim-k achim-k mentioned this pull request Jun 4, 2024
achim-k added a commit that referenced this pull request Jun 4, 2024
### Changelog
Remove most iron `test_msgs` messages

### Docs
None

### Description
#14 added additional `test_msgs` message definitions which caused
issues, especially due to `wstring` usage in `test_msgs/WStrings`. This
PR removes these additional message files again, leaving just
`test_msgs/Builtins.msg` which is also included in galactic and humble.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants