refactor: Update repository update calls to use SaveChangesAsync()

foxminchan · Aug 30, 2024 · 23c8735 · 23c8735
1 parent 7f91619
commit 23c8735
Show file tree

Hide file tree

Showing 12 changed files with 16 additions and 19 deletions.
diff --git a/src/BookWorm.Catalog/Features/Books/Delete/DeleteBookCommand.cs b/src/BookWorm.Catalog/Features/Books/Delete/DeleteBookCommand.cs
@@ -14,7 +14,7 @@ public async Task<Result> Handle(DeleteBookCommand request, CancellationToken ca
 
         book.Delete();
 
-        await repository.UpdateAsync(book, cancellationToken);
+        await repository.SaveChangesAsync(cancellationToken);
 
         return Result.Success();
     }

diff --git a/src/BookWorm.Catalog/Features/Books/RemoveImage/RemoveBookImageCommand.cs b/src/BookWorm.Catalog/Features/Books/RemoveImage/RemoveBookImageCommand.cs
@@ -14,7 +14,7 @@ public async Task<Result> Handle(RemoveBookImageCommand request, CancellationTok
 
         await azurite.DeleteFileAsync(book.ImageUrl!, cancellationToken);
         book.RemoveImage();
-        await repository.UpdateAsync(book, cancellationToken);
+        await repository.SaveChangesAsync(cancellationToken);
 
         return Result.Success();
     }

diff --git a/src/BookWorm.Catalog/Features/Books/Update/UpdateBookCommand.cs b/src/BookWorm.Catalog/Features/Books/Update/UpdateBookCommand.cs
@@ -39,7 +39,7 @@ public async Task<Result> Handle(UpdateBookCommand request, CancellationToken ca
             book.Embed(embedding);
         }
 
-        await repository.UpdateAsync(book, cancellationToken);
+        await repository.SaveChangesAsync(cancellationToken);
 
         return Result.Success();
     }

diff --git a/...ookWorm.Catalog/IntegrationEvents/EventHandlers/FeedbackCreatedIntegrationEventHandler.cs b/...ookWorm.Catalog/IntegrationEvents/EventHandlers/FeedbackCreatedIntegrationEventHandler.cs
@@ -29,7 +29,7 @@ public async Task Consume(ConsumeContext<FeedbackCreatedIntegrationEvent> contex
 
         try
         {
-            await repository.UpdateAsync(book);
+            await repository.SaveChangesAsync();
         }
         catch (Exception)
         {

diff --git a/...ookWorm.Catalog/IntegrationEvents/EventHandlers/FeedbackDeletedIntegrationEventHandler.cs b/...ookWorm.Catalog/IntegrationEvents/EventHandlers/FeedbackDeletedIntegrationEventHandler.cs
@@ -25,7 +25,7 @@ public async Task Consume(ConsumeContext<FeedbackDeletedIntegrationEvent> contex
 
         book.RemoveRating(@event.Rating);
 
-        await repository.UpdateAsync(book);
+        await repository.SaveChangesAsync();
     }
 }
 

diff --git a/src/BookWorm.Ordering/Features/Orders/Cancel/CancelOrderCommand.cs b/src/BookWorm.Ordering/Features/Orders/Cancel/CancelOrderCommand.cs
@@ -17,7 +17,7 @@ public async Task<Result> Handle(CancelOrderCommand request, CancellationToken c
 
         order.MarkAsCanceled();
 
-        await repository.UpdateAsync(order, cancellationToken);
+        await repository.SaveChangesAsync(cancellationToken);
 
         var email = identityService.GetEmail();
 

diff --git a/src/BookWorm.Ordering/Features/Orders/Complete/CompleteOrderCommand.cs b/src/BookWorm.Ordering/Features/Orders/Complete/CompleteOrderCommand.cs
@@ -17,7 +17,7 @@ public async Task<Result> Handle(CompleteOrderCommand request, CancellationToken
 
         order.MarkAsCompleted();
 
-        await repository.UpdateAsync(order, cancellationToken);
+        await repository.SaveChangesAsync(cancellationToken);
 
         var email = identityService.GetEmail();
 

diff --git a/tests/BookWorm.Catalog.UnitTests/Application/Books/DeleteBookHandlerTest.cs b/tests/BookWorm.Catalog.UnitTests/Application/Books/DeleteBookHandlerTest.cs
@@ -37,7 +37,7 @@ public async Task GivenRequest_ShouldDeleteBook_WhenBookExists()
             x => x.GetByIdAsync(It.IsAny<Guid>(), It.IsAny<CancellationToken>()),
             Times.Once);
         _bookRepositoryMock.Verify(
-            x => x.UpdateAsync(It.IsAny<Book>(), It.IsAny<CancellationToken>()),
+            x => x.SaveChangesAsync(It.IsAny<CancellationToken>()),
             Times.Once);
     }
 
@@ -63,7 +63,7 @@ public async Task GivenRequest_ShouldReturnNotFound_WhenBookDoesNotExist()
             x => x.GetByIdAsync(It.IsAny<Guid>(), It.IsAny<CancellationToken>()),
             Times.Once);
         _bookRepositoryMock.Verify(
-            x => x.UpdateAsync(It.IsAny<Book>(), It.IsAny<CancellationToken>()),
+            x => x.SaveChangesAsync(It.IsAny<CancellationToken>()),
             Times.Never);
     }
 }
diff --git a/tests/BookWorm.Catalog.UnitTests/Application/Books/RemoveImageHandlerTest.cs b/tests/BookWorm.Catalog.UnitTests/Application/Books/RemoveImageHandlerTest.cs
@@ -30,9 +30,6 @@ public async Task GivenValidRemoveBookImageCommand_ShouldRemoveBookImageAndRetur
         _azuriteMock.Setup(a => a.DeleteFileAsync(book.ImageUrl!, It.IsAny<CancellationToken>()))
             .Returns(Task.CompletedTask);
 
-        _repositoryMock.Setup(r => r.UpdateAsync(book, It.IsAny<CancellationToken>()))
-            .Returns(Task.CompletedTask);
-
         var command = new RemoveBookImageCommand(bookId);
 
         // Act
@@ -61,7 +58,7 @@ public async Task GivenNonExistentBookId_ShouldThrowNotFoundException()
 
         _repositoryMock.Verify(r => r.GetByIdAsync(bookId, It.IsAny<CancellationToken>()), Times.Once);
         _azuriteMock.Verify(a => a.DeleteFileAsync(It.IsAny<string>(), It.IsAny<CancellationToken>()), Times.Never);
-        _repositoryMock.Verify(r => r.UpdateAsync(It.IsAny<Book>(), It.IsAny<CancellationToken>()), Times.Never);
+        _repositoryMock.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Never);
     }
 
     [Fact]

diff --git a/tests/BookWorm.Catalog.UnitTests/Application/Books/UpdateBookHandlerTests.cs b/tests/BookWorm.Catalog.UnitTests/Application/Books/UpdateBookHandlerTests.cs
@@ -45,7 +45,7 @@ public async Task GivenValidUpdateBookCommand_ShouldReturnSuccess()
         // Assert
         result.IsSuccess.Should().BeTrue();
         _repositoryMock.Verify(r => r.GetByIdAsync(bookId, It.IsAny<CancellationToken>()), Times.Once);
-        _repositoryMock.Verify(r => r.UpdateAsync(book, It.IsAny<CancellationToken>()), Times.Once);
+        _repositoryMock.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Once);
 
         book.Name.Should().Be("Updated Name");
         book.Description.Should().Be("Updated Description");
@@ -73,7 +73,7 @@ public async Task GivenNonExistentBookId_ShouldThrowNotFoundException()
         await act.Should().ThrowAsync<NotFoundException>();
 
         _repositoryMock.Verify(r => r.GetByIdAsync(bookId, It.IsAny<CancellationToken>()), Times.Once);
-        _repositoryMock.Verify(r => r.UpdateAsync(It.IsAny<Book>(), It.IsAny<CancellationToken>()), Times.Never);
+        _repositoryMock.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Never);
     }
 
     [Theory]

diff --git a/tests/BookWorm.Ordering.UnitTests/Application/Orders/CancelOrderHandlerTests.cs b/tests/BookWorm.Ordering.UnitTests/Application/Orders/CancelOrderHandlerTests.cs
@@ -32,7 +32,7 @@ public async Task GivenValidOrderId_ShouldCancelOrderAndPublishEvent()
         // Assert
         result.IsSuccess.Should().BeTrue();
         order.Status.Should().Be(Status.Canceled);
-        _repository.Verify(x => x.UpdateAsync(order, It.IsAny<CancellationToken>()), Times.Once);
+        _repository.Verify(x => x.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Once);
         _publishEndpoint.Verify(
             x => x.Publish(It.IsAny<OrderCancelledIntegrationEvent>(), It.IsAny<CancellationToken>()), Times.Once);
     }
@@ -50,7 +50,7 @@ public async Task GivenInvalidOrderId_ShouldThrowNotFoundException_WhenOrderNotF
 
         // Assert
         await act.Should().ThrowAsync<NotFoundException>();
-        _repository.Verify(x => x.UpdateAsync(It.IsAny<Order>(), It.IsAny<CancellationToken>()), Times.Never);
+        _repository.Verify(x => x.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Never);
         _publishEndpoint.Verify(
             x => x.Publish(It.IsAny<OrderCancelledIntegrationEvent>(), It.IsAny<CancellationToken>()), Times.Never);
     }

diff --git a/tests/BookWorm.Ordering.UnitTests/Application/Orders/CompleteOrderHandlerTests.cs b/tests/BookWorm.Ordering.UnitTests/Application/Orders/CompleteOrderHandlerTests.cs
@@ -32,7 +32,7 @@ public async Task GivenValidOrderId_ShouldCompleteOrderAndPublishEvent()
         // Assert
         result.IsSuccess.Should().BeTrue();
         order.Status.Should().Be(Status.Completed);
-        _repository.Verify(x => x.UpdateAsync(order, It.IsAny<CancellationToken>()), Times.Once);
+        _repository.Verify(x => x.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Once);
         _publishEndpoint.Verify(
             x => x.Publish(It.IsAny<OrderCompletedIntegrationEvent>(), It.IsAny<CancellationToken>()), Times.Once);
     }
@@ -50,7 +50,7 @@ public async Task GivenInvalidOrderId_ShouldThrowNotFoundException_WhenOrderNotF
 
         // Assert
         await act.Should().ThrowAsync<NotFoundException>();
-        _repository.Verify(x => x.UpdateAsync(It.IsAny<Order>(), It.IsAny<CancellationToken>()), Times.Never);
+        _repository.Verify(x => x.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Never);
         _publishEndpoint.Verify(
             x => x.Publish(It.IsAny<OrderCompletedIntegrationEvent>(), It.IsAny<CancellationToken>()), Times.Never);
     }