Make slack_webhook as non optional parameter #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial the CLI argument slack_webhook was optional, even though other options related to notificatin were required to be passed (Thanks to Kirill for raising this point to me): - app name - app version - notification context I initially made the slack_webhook option to convey the fact that the notification system is pluggable and you could instead optionally integrate other providers like Discord or Microsoft teams. Making it as non optional would indicate that this tool is tied to slack. I discovered that this problem is solved by clap's ArgGroup, so I have converted the solution to that. This also makes sure that we pass atleast one parameter of the NotifyHook struct.
snoyberg
reviewed
Jul 25, 2024
snoyberg
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially the CLI argument slack_webhook was optional, even though other options related to notification were required to be passed (Thanks to Kirill for raising this point to me):
I made the slack_webhook optional to convey the fact that the notification system is pluggable and you could instead optionally integrate other providers like Discord or Microsoft teams. Making it as non optional would indicate that this tool is tied to slack.
I discovered that this problem is solved by clap's ArgGroup, so I have converted the solution to that. This also makes sure that we pass atleast one parameter of the NotifyHook struct.