Supporting assigning EIP to single node ASG instance. #232
Conversation
Magicloud
changed the title
There was a problem hiding this comment.
@Magicloud, can you split the module updates from the other changes to the examples? those changes can be kept on a branch and we can review again when there's more time.
Magicloud
force-pushed
the
eip
branch
2 times, most recently
from
e160114
to
269149c
Compare
|
@ketzacoatl Latest PR contains the modification to |
|
|
||
| module "init-install-awscli" { | ||
| source = "../init-snippet-install-awscli" | ||
| } |
There was a problem hiding this comment.
Does this snippet make the module ubuntu-only? or would this still work with centos?
There was a problem hiding this comment.
Yes, Ubuntu only. I think it won't be hard to support CentOS.
There was a problem hiding this comment.
@Magicloud will we support CentOS?
There was a problem hiding this comment.
@Magicloud any update on this?
|
@Magicloud what's the status of this PR? |
|
@qrilka Have not attended to this for a while. Last I checked, the function worked. But now it contains conflicts with master. Will repair. |
Magicloud
force-pushed
the
eip
branch
2 times, most recently
from
fa52cd5
to
f092273
Compare
Since it is single node, binding an EIP to the instance is possible. And it eases other things since the public interface is constant. Add assign_eip variable to single-node-asg. If turns it on, an EIP will be allocated, and assocated with the instance. Scope VPC is specified in case the account does not have a default VPC.
|
This was tested in a couple of cases using the branch https://github.com/fpco/terraform-aws-foundation/tree/ec2-connect-tunnel |
Tested via single-node-asg-test example. Fixes #205.
Module iam-instance-profile is necessary for this change.
name: Pull request template
about: Make a PR to terraform-aws-foundation
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.
- For new
modulesthis would entail example code for how to use the module or some explanation in the module readme.- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.