Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

module/init-snippet-attach-ebs-volume: Manually make device name for attached EBS volume. #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Magicloud
Copy link
Contributor

Due to Linux kernel and Distro changes, an attched EBS volume may not get the specified device name (Ref https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html). Hence logic following may break since specified device does not exist.

This change uses Linux trick to manually setup (if it has not) the device name, so other logic can be static, without guessing which device is it.


name: Pull request template
about: Make a PR to terraform-aws-foundation

Please include the following in your PR:

Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's. Including these will more likely lead
to your PR being reviewed and accepted.

  • Update the changelog
  • Make sure that modules and files are documented. This can be done inside the module and files.
  • Make sure that new modules directories contain a basic README.md file.
  • Make sure that the module is added to tests/main.tf
  • Make sure that the linting passes on CI.
  • Make sure that there is an up to date example for your code:
    - For new modules this would entail example code for how to use the module or some explanation in the module readme.
    - For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
  • Make sure that there is a manual CI trigger that can test the deployment.

Copy link
Contributor

@ketzacoatl ketzacoatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That LGTM, we can merge after we define tests for QA, and have pastes/screenshots/etc confirming the changes works in those QA scenarios.

…attached EBS volume.

Due to Linux kernel and Distro changes, an attched EBS volume may not get the specified device name (Ref https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/device_naming.html). Hence logic following may break since specified device does not exist.

This change uses Linux trick to manually setup (if it has not) the device name, so other logic can be static, without guessing which device is it.
@ketzacoatl
Copy link
Contributor

@Magicloud what are next steps for this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants