Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Switch CI to Github Actions #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Switch CI to Github Actions #320

wants to merge 2 commits into from

Conversation

snoyberg
Copy link
Member

@snoyberg snoyberg commented Apr 7, 2020

No description provided.

@snoyberg snoyberg requested a review from ketzacoatl April 7, 2020 03:57
@ketzacoatl
Copy link
Contributor

cc @mcgirr / @Magicloud

Copy link
Contributor

@ketzacoatl ketzacoatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like github actions require using a docker image, and we will not have a default build image with our tools, so we should include the docker image in the repo as well?

@mcgirr
Copy link
Contributor

mcgirr commented Apr 14, 2020

It sounds like github actions require using a docker image, and we will not have a default build image with our tools, so we should include the docker image in the repo as well?

I'm getting up to speed with Github actions and will have a better response soon but if this is the case then yes I think that makes sense.

@snoyberg
Copy link
Member Author

This PR includes a workflow for building the Docker image used by the lint workflow.

@mcgirr
Copy link
Contributor

mcgirr commented Jul 2, 2020

I'm more familiar with GitHub Workflows/Actions now. I could shift back to review this PR if that's wanted.

@ketzacoatl
Copy link
Contributor

@mcgirr, sure, it would be good to bring CI back for this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants