Regression test 38 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorfairKing
commented
Mar 22, 2021
| output <- S.hGet outHandle (S.length contents) | ||
| when (output /= contents) $ fail "failed to read." | ||
|
|
||
|
|
||
| -- These tests fail on older GHCs/process package versions | ||
| -- because, apparently, waitForProcess isn't interruptible. See | ||
| -- https://github.com/fpco/typed-process/pull/26#issuecomment-505702573. |
There was a problem hiding this comment.
I just found this comment. I looks like it might be relevant.
|
I'm surprised to see that ci doesn't fail on this test... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @snoyberg This is a regression test for the problem in #38.
I also already added the fix that you suggested and it does indeed seem to fix the issue.
I made this PR here because I couldn't reproduce the problem in
processinstead.I'd be happy to close this PR here and open a similar one for haskell/process#204 instead if we find a way to reproduce the issue there.