Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File: On errors with DirFds, print the path to the directory. #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nh2
Copy link
Member

@nh2 nh2 commented Nov 7, 2022

Example: Turns errors like

openAnonymousTempFileFromDir: permission denied (Permission denied)

into

openAnonymousTempFileFromDir: /tmp/unwritable-test-dir1218657: permission denied (Permission denied)

so that the user can see for which directory write permissions are missing.


I found it difficult to figure errors in production if I am not told where e.g. permission errors lie without this.

Example: Turns errors like

```
openAnonymousTempFileFromDir: permission denied (Permission denied)
```

into

```
openAnonymousTempFileFromDir: /tmp/unwritable-test-dir1218657: permission denied (Permission denied)
```

so that the user can see for which directory write permissions are missing.
@snoyberg
Copy link
Member

Looks like this is failing on Mac

@nh2
Copy link
Member Author

nh2 commented Nov 12, 2022

From the error message, I haven't managed yet to figure out why it's failing. It says

predicate failed on expected exception: IOException (/private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/unwritable-test-dir23032: openBinaryTempFile: permission denied (Permission denied))

which looks to me like the full path /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/unwritable-test-dir23032 is present in the exception (which is what the test ist checking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants