Add a CONTRIBUTING.md file with checks to execute before creating a PR #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fphammerle
requested changes
Sep 20, 2025
| @@ -0,0 +1,53 @@ | |||
| # Contributing | |||
|
|
|||
| When contributing to this repository, please first discuss the change you wish to make via issue with the owners of this repository before making a change. | |||
There was a problem hiding this comment.
Thanks for adding CONTRIBUTING.md!
I would say prior discussion is not necessary for all pull requests.
It would imho make sense if the planned pulled request introduced breaking changes or new features requiring lots of dev work.
Comment on lines
+7
to
+8
| 1. Ensure any install or build dependencies are removed before the end of the layer when doing a | ||
| build. |
There was a problem hiding this comment.
Could you explain what you mean here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to reject if you don't agree with the content. But the file would have helped me with my contribution.