Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to using the default SPI build version for documentation builds #6

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

daveverwer
Copy link
Contributor

We recently switched SPI to use 6.0 by default. There would be no harm in leaving this as explicitly set to 6.0 for now, but while I remember it’s still here I thought I’d revert it so that when we get to 6.5, this explicitly set version hasn’t rolled off the bottom of what we support.

Copy link
Owner

@fpseverino fpseverino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks a lot

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (8b0fbc9) to head (f8e283a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files           8        8           
  Lines         523      523           
=======================================
  Hits          465      465           
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fpseverino fpseverino merged commit 054c12f into fpseverino:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants