Add support for loading mermaid via esm module #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Changes
extra_javascript
is no longer possible for version >= 10. This probably requires readme changes not included in this PR. It may be possible for users to include a simple JS file that imports mermaid via esm here instead.Context
From mermaid v10 onwards mermaid is only distributed as an ESM module. See Mermaid #3590 for discussion on this change.
Users will probably notice this problem if they are following the readme recommended way of loading the latest version of mermaid through
extra_javascript
as includinghttps://unpkg.com/mermaid/dist/mermaid.min.js
resolves to e.ghttps://unpkg.com/[email protected]/dist/mermaid.min.js
which does not exist.Looking around other projects this seems to be a common issue for libraries including mermaid.
To resolve this mermaid must now be explicitly imported through e.g
To achieve this this PR makes several changes:
<script src="...">
or<script type="module">
as appropriate.