Skip to content

Conversation

afidegnum
Copy link
Contributor

Please add the following cargo updates while I work on others.

@afidegnum
Copy link
Contributor Author

Are you still using minify?

@arctic-hen7
Copy link
Member

Perfect, thanks! Yes, as far as I can remember, minify is still being used. Just re-running that failing check and then good to merge.

@arctic-hen7
Copy link
Member

That test has failed again, @afidegnum could you run locally and investigate the preload test?

@afidegnum
Copy link
Contributor Author

I was able to run perseus serve successfully, but I will need to look at the test aspects also. I posted a message on the "Issue". Can we have a discussion on discord on porting to Sycamore 0.9 ?

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can re-enable PR CI runs, I'm happy to merge this once preload tests are passing (or once there's a concrete reason they aren't).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you disabled pull request CI runs? It's important to have these so we can make sure PRs work in the codebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that from the repo I forked not the push committed in order to properly identify the bug. once done, I will submit the pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, it's just that CI runs on pull requests have been disabled in the commits here. Once that's fixed I'm happy to merge this.

updt
updT
error fix
fix rust errors
@afidegnum
Copy link
Contributor Author

HI, I have been able to fix the issues, can you pls accept the pull request?
working on the sycamore upgrade

@afidegnum afidegnum requested a review from arctic-hen7 July 13, 2025 07:50
@afidegnum
Copy link
Contributor Author

I can't see the changes you requested, can you please give details?

@arctic-hen7
Copy link
Member

Thanks! Will have a look at this by tomorrow.

@afidegnum
Copy link
Contributor Author

have you checked? is it ok?

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for the delay with this, life very much happened! One little change to make sure the CI script still works, and then this is good to merge. Preload tests seem to be passing now, thanks!

Copy link
Member

@arctic-hen7 arctic-hen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@arctic-hen7
Copy link
Member

Just re-running the failing capsules test, should be fine. Then will merge.

@arctic-hen7 arctic-hen7 merged commit 383a96a into framesurge:main Aug 2, 2025
44 of 46 checks passed
@afidegnum
Copy link
Contributor Author

Thanks, I'm investigating on the failed test and working on the sycamore updates too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants