feat: implement GitHub Actions workflow for building#486
Merged
Conversation
…ions and update entrypoint script for user/group renumbering
…r improved compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the container build and deployment pipeline, focusing on multi-platform image builds, enhanced Podman quadlet templates, and improved runtime user handling. The changes streamline the CI/CD workflow, standardize image references, and ensure containers run with correct user permissions across environments.
CI/CD Pipeline Enhancements:
.github/workflows/build.ymlto build, tag, and push multi-platform images (linux/amd64,linux/arm64) using Podman and Buildah, with caching and manifest merging for efficient and reliable releases.Podman Quadlet Template Updates:
frankenphp-octanequadlet stubs (app,horizon,inertia-ssr,reverb,schedule) to use a configurable{{image}}placeholder (defaulting to a registry image), switchAutoUpdatetoregistry, and setPUID/PGIDenvironment variables for user mapping. [1] [2] [3] [4] [5]substitutionsconfig inconfig/podman.phpto allow custom placeholder values (e.g.,{{image}}) in quadlet templates.Container Runtime Improvements:
Containerfileto installgosuand ensure the container runs asrootby default, so entrypoint logic can safely remap thedockeruser/group to the host's PUID/PGID before dropping privileges. [1] [2]entrypoint.shto dynamically renumber thedockeruser/group at runtime, ensuring correct file ownership and permission handling regardless of the host user's UID/GID.Platform-Specific Dependency Handling:
Containerfileto only install certain video driver packages (libmfx-gen1.2,libvpl2,intel-media-va-driver-non-free) onamd64builds, reducing unnecessary dependencies on other platforms.