Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark tailwindcss as optional peer dependency #266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amannn
Copy link

@amannn amannn commented Aug 17, 2023

Mark tailwindcss as optional peer dependency

Description

When this plugin is included in a shareable config, the usage of Tailwind might be optional (see e.g. https://github.com/molindo/eslint-config-molindo).

Other popular ESLint plugin mark closely related peer dependencies as optional too for this reason (see e.g. eslint-plugin-jest

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I know the strategy to be working from other ESLint plugins.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@amannn amannn marked this pull request as ready for review August 17, 2023 07:04
@amannn
Copy link
Author

amannn commented Jan 11, 2024

@francoismassart Any chance this could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant