Skip to content

Commit

Permalink
Update C/C++ Linter Workflow (#59)
Browse files Browse the repository at this point in the history
This commit updates the C/C++ Linter workflow at `.github/workflows/cpp-linter.yml`. The style is changed from `llvm` to `file` and the action ignores now also `Qt/Qt` and `build/CMakeFiles` folder that are out of the repositories changing reach. As a future restriction, this workflow is only allowed to write status and the remaining is changed to read only.

* Change style to file
* Add Qt to the ignored directories
* Add permissions accordingly for the workflow
* Add `build/CMakeFiles` to the ignore paths
  • Loading branch information
franziska-wegner committed Dec 29, 2023
1 parent 5c5a16c commit b7ea069
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions .github/workflows/cpp-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ concurrency:
env:
QT_VERSION: "6.2.0"

permissions:
contents: read
packages: read
# To report GitHub Actions status checks
statuses: write

jobs:
cpp-linter:

Expand Down Expand Up @@ -111,16 +117,16 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: llvm #file
tidy-checks: boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*
style: "file" #llvm
tidy-checks: "boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*"
files-changed-only: false
lines-changed-only: false
no-lgtm: false
# The following value will only update a single comment
# in a pull request's thread. Set it to false to disable the comment.
# Set it to true to post a new comment (and delete the old comment).
thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
ignore: external
ignore: "external|Qt|build/CMakeFiles"

- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
Expand Down

0 comments on commit b7ea069

Please sign in to comment.