Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the warnings D9002 and D9025 caused by -Ofast Flag for MSVC #101

Conversation

franziska-wegner
Copy link
Owner

@franziska-wegner franziska-wegner commented Jan 6, 2024

This PR removes the warnings D9002 and D9025, which is caused by the -Ofast flag under windows MSVC.

cl : command line
warning D9025: overriding '/Os' with '/Ot' [D:\a\egoa\egoa\build\EGOA.vcxproj]
cl : command line
warning D9002: ignoring unknown option '-Of' [D:\a\egoa\egoa\build\EGOA.vcxproj]
cl : command line warning D9002: ignoring unknown option
'-Oa' [D: \a\egoa\egoa\build\EGOA.vcxproj]
Screenshot 2024-01-06 at 8 53 25 AM Screenshot 2024-01-06 at 8 53 22 AM Screenshot 2024-01-06 at 8 50 26 AM

@franziska-wegner franziska-wegner self-assigned this Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdce041) 94.57% compared to head (0386066) 94.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          55       55           
  Lines        5049     5049           
=======================================
  Hits         4775     4775           
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franziska-wegner franziska-wegner force-pushed the franziska-wegner/2024/january/CI/remove-windows-compiler-warnings branch from f098e6f to 0386066 Compare January 6, 2024 19:11
@franziska-wegner franziska-wegner added enhancement New feature or request compiler warnings Ignore or remove compiler warnings labels Jan 6, 2024
@franziska-wegner franziska-wegner changed the title Check if the warning is cause by the -Ofast flag Removes the warnings D9002 and D9025 caused by -Ofast Flag for MSVC Jan 6, 2024
@franziska-wegner franziska-wegner enabled auto-merge (squash) January 6, 2024 19:16
@franziska-wegner franziska-wegner merged commit 8edb316 into main Jan 6, 2024
17 checks passed
@franziska-wegner franziska-wegner deleted the franziska-wegner/2024/january/CI/remove-windows-compiler-warnings branch January 6, 2024 19:22
github-actions bot added a commit that referenced this pull request Jan 6, 2024
…r Windows `MSVC` (#101)

* Check if the warning is cause by the -Ofast flag
* Differentiate between windows and unix 8edb316
github-actions bot added a commit that referenced this pull request Jan 6, 2024
…r Windows `MSVC` (#101)

* Check if the warning is cause by the -Ofast flag
* Differentiate between windows and unix 8edb316
github-actions bot added a commit that referenced this pull request Jan 6, 2024
…r Windows `MSVC` (#101)

* Check if the warning is cause by the -Ofast flag
* Differentiate between windows and unix 8edb316
github-actions bot added a commit that referenced this pull request Jan 6, 2024
…r Windows `MSVC` (#101)

* Check if the warning is cause by the -Ofast flag
* Differentiate between windows and unix 8edb316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler warnings Ignore or remove compiler warnings enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant