Enable Tests in EGOA #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: tests/CMakeLists.txt
Changes to be committed: new file: tests/DataStructures/TestBound.cpp new file: tests/DataStructures/TestBound.hpp
Changes to be committed: modified: tests/CMakeLists.txt
franziska-wegner
force-pushed
the
franziska-wegner/2023/december/tests/enable-TestBound
branch
from
8ce8e12
to
76a6592
Compare
Changes to be committed: modified: CMakeLists.txt
Changes to be committed: modified: CMakeLists.txt
Why: * add subdirectory in CMake requires the CMakeFile that is not downloaded yet Changes to be committed: modified: .github/workflows/cmake-multi-platform.yml
franziska-wegner
commented
Dec 7, 2023
franziska-wegner
added this to the Add/Implement DataStructure Tests Successfully milestone
Changes to be committed: modified: CMakeLists.txt
Changes to be committed: modified: CMakeLists.txt
Changes to be committed: modified: CMakeLists.txt
…tected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in TestBound.obj [D:\a\egoa\egoa\build\tests\TestBound.vcxproj] See note in: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY Changes to be committed: modified: CMakeLists.txt
Changes to be committed: modified: tests/DataStructures/TestBound.cpp
Changes to be committed: modified: CMakeLists.txt
D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src/gtest-port.cc(844): error: Failed
1: Syntax error at index 42 in simple regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.
1: Condition: minimum_ <= maximum_": ')' is unsupported.
1:
1: Running main() from D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src\gtest_main.cc
1: D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
1: Result: died but not with expected error.
1: Expected: contains regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.\n Condition: minimum_ <= maximum_"
1: Actual msg:
1: [ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
1: [ DEATH ] Condition: minimum_ <= maximum_
1:
1: [ FAILED ] TestBound.DeathTest (146 ms)
Changes to be committed:
modified: tests/Helper/TestHelper.hpp
…Bound<double>::Bound.\n Condition".
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
1: Result: died but not with expected error.
1: Expected: contains regular expression ".* assertion failed at .*Bound.hpp:.* inside Bound.\n Condition: minimum_ <= maximum_"
1: Actual msg:
1: [ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
1: [ DEATH ] Condition: minimum_ <= maximum_
Changes to be committed:
modified: tests/Helper/TestHelper.hpp
franziska-wegner
commented
Dec 8, 2023
franziska-wegner
commented
Dec 8, 2023
franziska-wegner
deleted the
franziska-wegner/2023/december/tests/enable-TestBound
branch
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2023
Enable TestBound in the CMakeFile of the test folder. In this version, we duplicate the CMake and CMake builds to download the Google Test Framework. This is required due to the fact that with the current option ExternalProject_Add the external project is only downloaded and installed during the first CMake build. We will change this in another PR to align it with the framework Eigen.
Tests that work on linux "obviously" do not work always with windows ¯_(ツ)_/¯, e.g., in debug mode.
The above test fail was due to the fact that (.*) regular expression is not supported, but .* is. The issue is only happening on Windows. In addition, the message looks a little bit different on Windows compared to Unix systems. The output differs in "inside Bound.\n Condition" (Unix) from "inside egoa::Bound::Bound.\n Condition" (Windows).
Commits:
* Enable TestBound in the CMakeFile
* Add TestBound testcases
* Remove Gurobi Library from TestBound
* Check whether Windows and MacOS find the include with that file
* Replace find_package with own find CMake for Google Testframework
* Downloads need an initial build then the data is on the disk
Why:
* add subdirectory in CMake requires the CMakeFile that is not downloaded yet
* Check sudo
* The error in the tests is due to wrong runtime library
* Does DLL works
* Check without debug
* Resolve libcpmt.lib(StlLCMapStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in TestBound.obj [D:\a\egoa\egoa\build\tests\TestBound.vcxproj]
See note in: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
* Fix a label mistake
* Add more verbose to the test output to understand what is going on
* Check if differentiation is necessary between Debug and Release
* Follow the error given in Windows debug death test "')' is unsupported"
D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src/gtest-port.cc(844): error: Failed
Syntax error at index 42 in simple regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.
Condition: minimum_ <= maximum_": ')' is unsupported.
Running main() from D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src\gtest_main.cc
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_
[ FAILED ] TestBound.DeathTest (146 ms)
* The output differs in "inside Bound.\n Condition" from "inside egoa::Bound<double>::Bound.\n Condition".
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression ".* assertion failed at .*Bound.hpp:.* inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_ 63a79b1
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2023
Enable TestBound in the CMakeFile of the test folder. In this version, we duplicate the CMake and CMake builds to download the Google Test Framework. This is required due to the fact that with the current option ExternalProject_Add the external project is only downloaded and installed during the first CMake build. We will change this in another PR to align it with the framework Eigen.
Tests that work on linux "obviously" do not work always with windows ¯_(ツ)_/¯, e.g., in debug mode.
The above test fail was due to the fact that (.*) regular expression is not supported, but .* is. The issue is only happening on Windows. In addition, the message looks a little bit different on Windows compared to Unix systems. The output differs in "inside Bound.\n Condition" (Unix) from "inside egoa::Bound::Bound.\n Condition" (Windows).
Commits:
* Enable TestBound in the CMakeFile
* Add TestBound testcases
* Remove Gurobi Library from TestBound
* Check whether Windows and MacOS find the include with that file
* Replace find_package with own find CMake for Google Testframework
* Downloads need an initial build then the data is on the disk
Why:
* add subdirectory in CMake requires the CMakeFile that is not downloaded yet
* Check sudo
* The error in the tests is due to wrong runtime library
* Does DLL works
* Check without debug
* Resolve libcpmt.lib(StlLCMapStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in TestBound.obj [D:\a\egoa\egoa\build\tests\TestBound.vcxproj]
See note in: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
* Fix a label mistake
* Add more verbose to the test output to understand what is going on
* Check if differentiation is necessary between Debug and Release
* Follow the error given in Windows debug death test "')' is unsupported"
D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src/gtest-port.cc(844): error: Failed
Syntax error at index 42 in simple regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.
Condition: minimum_ <= maximum_": ')' is unsupported.
Running main() from D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src\gtest_main.cc
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_
[ FAILED ] TestBound.DeathTest (146 ms)
* The output differs in "inside Bound.\n Condition" from "inside egoa::Bound<double>::Bound.\n Condition".
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression ".* assertion failed at .*Bound.hpp:.* inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_ 63a79b1
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2023
Enable TestBound in the CMakeFile of the test folder. In this version, we duplicate the CMake and CMake builds to download the Google Test Framework. This is required due to the fact that with the current option ExternalProject_Add the external project is only downloaded and installed during the first CMake build. We will change this in another PR to align it with the framework Eigen.
Tests that work on linux "obviously" do not work always with windows ¯_(ツ)_/¯, e.g., in debug mode.
The above test fail was due to the fact that (.*) regular expression is not supported, but .* is. The issue is only happening on Windows. In addition, the message looks a little bit different on Windows compared to Unix systems. The output differs in "inside Bound.\n Condition" (Unix) from "inside egoa::Bound::Bound.\n Condition" (Windows).
Commits:
* Enable TestBound in the CMakeFile
* Add TestBound testcases
* Remove Gurobi Library from TestBound
* Check whether Windows and MacOS find the include with that file
* Replace find_package with own find CMake for Google Testframework
* Downloads need an initial build then the data is on the disk
Why:
* add subdirectory in CMake requires the CMakeFile that is not downloaded yet
* Check sudo
* The error in the tests is due to wrong runtime library
* Does DLL works
* Check without debug
* Resolve libcpmt.lib(StlLCMapStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in TestBound.obj [D:\a\egoa\egoa\build\tests\TestBound.vcxproj]
See note in: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
* Fix a label mistake
* Add more verbose to the test output to understand what is going on
* Check if differentiation is necessary between Debug and Release
* Follow the error given in Windows debug death test "')' is unsupported"
D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src/gtest-port.cc(844): error: Failed
Syntax error at index 42 in simple regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.
Condition: minimum_ <= maximum_": ')' is unsupported.
Running main() from D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src\gtest_main.cc
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_
[ FAILED ] TestBound.DeathTest (146 ms)
* The output differs in "inside Bound.\n Condition" from "inside egoa::Bound<double>::Bound.\n Condition".
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression ".* assertion failed at .*Bound.hpp:.* inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_ 63a79b1
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2023
Enable TestBound in the CMakeFile of the test folder. In this version, we duplicate the CMake and CMake builds to download the Google Test Framework. This is required due to the fact that with the current option ExternalProject_Add the external project is only downloaded and installed during the first CMake build. We will change this in another PR to align it with the framework Eigen.
Tests that work on linux "obviously" do not work always with windows ¯_(ツ)_/¯, e.g., in debug mode.
The above test fail was due to the fact that (.*) regular expression is not supported, but .* is. The issue is only happening on Windows. In addition, the message looks a little bit different on Windows compared to Unix systems. The output differs in "inside Bound.\n Condition" (Unix) from "inside egoa::Bound::Bound.\n Condition" (Windows).
Commits:
* Enable TestBound in the CMakeFile
* Add TestBound testcases
* Remove Gurobi Library from TestBound
* Check whether Windows and MacOS find the include with that file
* Replace find_package with own find CMake for Google Testframework
* Downloads need an initial build then the data is on the disk
Why:
* add subdirectory in CMake requires the CMakeFile that is not downloaded yet
* Check sudo
* The error in the tests is due to wrong runtime library
* Does DLL works
* Check without debug
* Resolve libcpmt.lib(StlLCMapStringW.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MT_StaticRelease' doesn't match value 'MD_DynamicRelease' in TestBound.obj [D:\a\egoa\egoa\build\tests\TestBound.vcxproj]
See note in: https://cmake.org/cmake/help/latest/variable/CMAKE_MSVC_RUNTIME_LIBRARY.html#variable:CMAKE_MSVC_RUNTIME_LIBRARY
* Fix a label mistake
* Add more verbose to the test output to understand what is going on
* Check if differentiation is necessary between Debug and Release
* Follow the error given in Windows debug death test "')' is unsupported"
D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src/gtest-port.cc(844): error: Failed
Syntax error at index 42 in simple regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.
Condition: minimum_ <= maximum_": ')' is unsupported.
Running main() from D:\a\egoa\egoa\external\GoogleTestFramework\googletest\src\gtest_main.cc
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression "(.*) assertion failed at (.*)Bound.hpp:(.*) inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_
[ FAILED ] TestBound.DeathTest (146 ms)
* The output differs in "inside Bound.\n Condition" from "inside egoa::Bound<double>::Bound.\n Condition".
D:\a\egoa\egoa\tests\DataStructures\TestBound.cpp(70): error: Death test: {egoa::Bound<> bound (3,1);}
Result: died but not with expected error.
Expected: contains regular expression ".* assertion failed at .*Bound.hpp:.* inside Bound.\n Condition: minimum_ <= maximum_"
Actual msg:
[ DEATH ] USAGE assertion failed at D:\a\egoa\egoa\include\DataStructures/Bound.hpp:48 inside egoa::Bound<double>::Bound.
[ DEATH ] Condition: minimum_ <= maximum_ 63a79b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable TestBound in the CMakeFile of the test folder. In this version, we duplicate the CMake and CMake builds to download the Google Test Framework. This is required due to the fact that with the current option
ExternalProject_Addthe external project is only downloaded and installed during the first CMake build. We will change this in another PR to align it with the frameworkEigen.Changes to be committed:
modified: tests/CMakeLists.txt
Tests that work on linux "obviously" do not work always with windows ¯_(ツ)_/¯, e.g., in debug mode.
The above test fail was due to the fact that
(.*)regular expression is not supported, but.*is. The issue is only happening on Windows. In addition, the message looks a little bit different on Windows compared to Unix systems. The output differs in "inside Bound.\n Condition" (Unix) from "inside egoa::Bound::Bound.\n Condition" (Windows).