Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Mapping Binary Heap #23

Conversation

franziska-wegner
Copy link
Owner

This PR introduces the first test for the mapping binary heap.

Changes to be committed:
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.cpp
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.hpp
@franziska-wegner franziska-wegner added the tests Add or update tests to EGOA label Dec 8, 2023
@franziska-wegner franziska-wegner self-assigned this Dec 8, 2023
@franziska-wegner franziska-wegner linked an issue Dec 8, 2023 that may be closed by this pull request
3 tasks
@franziska-wegner franziska-wegner marked this pull request as ready for review December 8, 2023 18:52
@franziska-wegner franziska-wegner enabled auto-merge (squash) December 8, 2023 18:52
@franziska-wegner
Copy link
Owner Author

franziska-wegner commented Dec 11, 2023

At the moment the death test fail and the issue happens mainly---with windows as exception---in the Release build mode, which makes sense as the assertions assert are not enabled in release mode.

The test framework returns the following warning that we try to avoid. Thus, we run the tests single threaded to have stable tests.

Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

franziska-wegner and others added 8 commits December 11, 2023 06:13
…Test warning

What?
Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.
@franziska-wegner franziska-wegner enabled auto-merge (squash) December 11, 2023 20:31
@franziska-wegner franziska-wegner merged commit aeec600 into main Dec 11, 2023
12 checks passed
@franziska-wegner franziska-wegner deleted the franziska-wegner/2023/december/tests/datastructures/mappingbinaryheap branch December 11, 2023 20:39
github-actions bot added a commit that referenced this pull request Dec 11, 2023
* Add tests for mapping binary heap

Changes to be committed:
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.cpp
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.hpp

* Enable the tests for MappingBinaryHeap within the framework
* Run test in single threaded mode to avoid Google Testframework Death Test warning

What?
Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

* Update test with assertion and exception handling differentiation
* Rename some TestFixtureNames
* Renaming some TestNames
* Change from parallel to j
* Add missing namespace ::testing::MatchesRegex
* Forgot an round brackets escape aeec600
github-actions bot added a commit that referenced this pull request Dec 11, 2023
* Add tests for mapping binary heap

Changes to be committed:
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.cpp
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.hpp

* Enable the tests for MappingBinaryHeap within the framework
* Run test in single threaded mode to avoid Google Testframework Death Test warning

What?
Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

* Update test with assertion and exception handling differentiation
* Rename some TestFixtureNames
* Renaming some TestNames
* Change from parallel to j
* Add missing namespace ::testing::MatchesRegex
* Forgot an round brackets escape aeec600
github-actions bot added a commit that referenced this pull request Dec 11, 2023
* Add tests for mapping binary heap

Changes to be committed:
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.cpp
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.hpp

* Enable the tests for MappingBinaryHeap within the framework
* Run test in single threaded mode to avoid Google Testframework Death Test warning

What?
Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

* Update test with assertion and exception handling differentiation
* Rename some TestFixtureNames
* Renaming some TestNames
* Change from parallel to j
* Add missing namespace ::testing::MatchesRegex
* Forgot an round brackets escape aeec600
github-actions bot added a commit that referenced this pull request Dec 11, 2023
* Add tests for mapping binary heap

Changes to be committed:
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.cpp
	new file:   tests/DataStructures/Container/TestMappingBinaryHeap.hpp

* Enable the tests for MappingBinaryHeap within the framework
* Run test in single threaded mode to avoid Google Testframework Death Test warning

What?
Warning: NG] /Users/runner/work/egoa/egoa/external/GoogleTestFramework/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times out.

* Update test with assertion and exception handling differentiation
* Rename some TestFixtureNames
* Renaming some TestNames
* Change from parallel to j
* Add missing namespace ::testing::MatchesRegex
* Forgot an round brackets escape aeec600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or update tests to EGOA
Projects
Development

Successfully merging this pull request may close these issues.

Test Mapping Binary Heap
1 participant