Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply MSVC Flag bigobj only to Debug Mode #51

Conversation

franziska-wegner
Copy link
Owner

This problem occurs in MSVC Debug mode only. Thus, we only add the required in debug mode only.

Changes to be committed:
	modified:   cmake/CompilerConfiguration.cmake
@franziska-wegner franziska-wegner self-assigned this Dec 26, 2023
@franziska-wegner franziska-wegner added the tests Add or update tests to EGOA label Dec 26, 2023
@franziska-wegner franziska-wegner marked this pull request as ready for review December 26, 2023 20:37
@franziska-wegner franziska-wegner enabled auto-merge (squash) December 26, 2023 20:37
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04a58a8) 93.26% compared to head (4764e00) 93.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          28       28           
  Lines        2731     2731           
=======================================
  Hits         2547     2547           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franziska-wegner franziska-wegner merged commit 9fb0083 into main Dec 26, 2023
15 checks passed
@franziska-wegner franziska-wegner deleted the franziska-wegner/2023/december/tests/change-MSVC-compiler-flag-to-debug-only branch December 26, 2023 20:47
github-actions bot added a commit that referenced this pull request Dec 26, 2023
This problem occurs in MSVC Debug mode only. Thus, we only add the required in debug mode only. 9fb0083
github-actions bot added a commit that referenced this pull request Dec 26, 2023
This problem occurs in MSVC Debug mode only. Thus, we only add the required in debug mode only. 9fb0083
github-actions bot added a commit that referenced this pull request Dec 26, 2023
This problem occurs in MSVC Debug mode only. Thus, we only add the required in debug mode only. 9fb0083
github-actions bot added a commit that referenced this pull request Dec 26, 2023
This problem occurs in MSVC Debug mode only. Thus, we only add the required in debug mode only. 9fb0083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or update tests to EGOA
Projects
Development

Successfully merging this pull request may close these issues.

1 participant