Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C/C++ Linter Workflow #59

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Update C/C++ Linter Workflow #59

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a960d3
Change style to file
franziska-wegner Dec 29, 2023
72c003a
Add Qt to the ignored directories
franziska-wegner Dec 29, 2023
2efbb32
Add parentheses
franziska-wegner Dec 29, 2023
d717af9
Add permissions accordingly for the workflow
franziska-wegner Dec 29, 2023
bf50d31
Add `build/CMakeFiles` to the ignore paths
franziska-wegner Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/cpp-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ concurrency:
env:
QT_VERSION: "6.2.0"

permissions:
contents: read
packages: read
# To report GitHub Actions status checks
statuses: write

jobs:
cpp-linter:

Expand Down Expand Up @@ -111,16 +117,16 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: llvm #file
tidy-checks: boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*
style: "file" #llvm
tidy-checks: "boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*"
files-changed-only: false
lines-changed-only: false
no-lgtm: false
# The following value will only update a single comment
# in a pull request's thread. Set it to false to disable the comment.
# Set it to true to post a new comment (and delete the old comment).
thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
ignore: external
ignore: "external|Qt|build/CMakeFiles"

- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
Expand Down
Loading