Better handling of unsuccessful Gibbs samplers

franzmohr · Jul 8, 2023 · 9b059d4 · 9b059d4
1 parent eb23a4e
commit 9b059d4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/R/submodel_test_statistics.R b/R/submodel_test_statistics.R
@@ -137,15 +137,13 @@ submodel_test_statistics <- function(object, ...){
       teststats[i, "r"] <- object[[i]][["model"]][["rank"]]
     }    
 
-    # Skip tests if posterior simulation was not successful
+    # Test if Gibbs sampler was successful
     if (!is.null(object[[i]][["error"]])) {
       if (object[[i]][["error"]]) {
         loglik[[pos[i]]] <- NA
-        next 
       }
     } else {
 
-
       if (tvp) {
         temp_pars <- list()
         length(temp_pars) <- tt
@@ -222,7 +220,7 @@ submodel_test_statistics <- function(object, ...){
             } else {
               A0 <- diag(k_domestic)
             }
-            u[, period] <- y[, period] - matrix(temp_pars[[period]][j, ], k_domestic) %*% x[, period] 
+            u[, period] <- A0 %*% y[, period] - matrix(temp_pars[[period]][j, ], k_domestic) %*% x[, period] 
           }
         } else {
           if (structural) {