Add m_datasetDefined

Todo: Merge functionality with openPMD#1316
franzpoeschel · Mar 24, 2023 · 54cd3bd · 54cd3bd
1 parent f362e2c
commit 54cd3bd
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/include/openPMD/RecordComponent.hpp b/include/openPMD/RecordComponent.hpp
@@ -440,12 +440,15 @@ OPENPMD_protected
 
     inline Data_t const &get() const
     {
+        // cannot call this in the const overload
+        // datasetDefined(*m_recordComponentData);
         return dynamic_cast<Data_t const &>(*m_attri);
     }
 
     inline Data_t &get()
     {
         auto &res = dynamic_cast<Data_t &>(*m_attri);
+        datasetDefined(res);
         return res;
     }
 

diff --git a/include/openPMD/backend/BaseRecordComponent.hpp b/include/openPMD/backend/BaseRecordComponent.hpp
@@ -49,6 +49,10 @@ namespace internal
          * instead defined via light-weight attributes.
          */
         bool m_isConstant = false;
+        /*
+         * ... document this ...
+         */
+        bool m_datasetDefined = false;
 
         BaseRecordComponentData(BaseRecordComponentData const &) = delete;
         BaseRecordComponentData(BaseRecordComponentData &&) = delete;
@@ -114,6 +118,8 @@ class BaseRecordComponent : virtual public Attributable
         return dynamic_cast<Data_t &>(*m_attri);
     }
 
+    void datasetDefined(Data_t &);
+
     BaseRecordComponent();
 }; // BaseRecordComponent
 

diff --git a/include/openPMD/backend/PatchRecordComponent.hpp b/include/openPMD/backend/PatchRecordComponent.hpp
@@ -121,12 +121,15 @@ OPENPMD_protected
 
     inline Data_t const &get() const
     {
+        // cannot call this in the const overload
+        // datasetDefined(*m_recordComponentData);
         return dynamic_cast<Data_t const &>(*m_attri);
     }
 
     inline Data_t &get()
     {
         auto &res = dynamic_cast<Data_t &>(*m_attri);
+        datasetDefined(res);
         return res;
     }
 }; // PatchRecordComponent

diff --git a/src/backend/BaseRecordComponent.cpp b/src/backend/BaseRecordComponent.cpp
@@ -91,4 +91,9 @@ BaseRecordComponent::BaseRecordComponent()
         std::make_shared<internal::BaseRecordComponentData>());
 }
 
+void BaseRecordComponent::datasetDefined(
+    internal::BaseRecordComponentData &data)
+{
+    data.m_datasetDefined = true;
+}
 } // namespace openPMD