Add m_datasetDefined

Todo: Merge functionality with openPMD#1316
franzpoeschel · Apr 13, 2023 · 9ad8bd5 · 9ad8bd5
1 parent f5e9144
commit 9ad8bd5
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 0 deletions.
diff --git a/include/openPMD/RecordComponent.hpp b/include/openPMD/RecordComponent.hpp
@@ -440,11 +440,14 @@ OPENPMD_protected
 
     inline Data_t const &get() const
     {
+        // cannot call this in the const overload
+        // datasetDefined(*m_recordComponentData);
         return *m_recordComponentData;
     }
 
     inline Data_t &get()
     {
+        setDatasetDefined(*m_recordComponentData);
         return *m_recordComponentData;
     }
 

diff --git a/include/openPMD/backend/BaseRecordComponent.hpp b/include/openPMD/backend/BaseRecordComponent.hpp
@@ -49,6 +49,10 @@ namespace internal
          * instead defined via light-weight attributes.
          */
         bool m_isConstant = false;
+        /*
+         * ... document this ...
+         */
+        bool m_datasetDefined = false;
 
         BaseRecordComponentData(BaseRecordComponentData const &) = delete;
         BaseRecordComponentData(BaseRecordComponentData &&) = delete;
@@ -166,6 +170,10 @@ class BaseRecordComponent : virtual public Attributable
         Attributable::setData(m_baseRecordComponentData);
     }
 
+    void setDatasetDefined(Data_t &);
+
+    bool datasetDefined() const;
+
     BaseRecordComponent();
     BaseRecordComponent(NoInit);
 }; // BaseRecordComponent

diff --git a/include/openPMD/backend/PatchRecordComponent.hpp b/include/openPMD/backend/PatchRecordComponent.hpp
@@ -124,11 +124,14 @@ OPENPMD_protected
 
     inline Data_t const &get() const
     {
+        // cannot call this in the const overload
+        // setDatasetDefined(*m_recordComponentData);
         return *m_patchRecordComponentData;
     }
 
     inline Data_t &get()
     {
+        setDatasetDefined(*m_patchRecordComponentData);
         return *m_patchRecordComponentData;
     }
 

diff --git a/src/backend/BaseRecordComponent.cpp b/src/backend/BaseRecordComponent.cpp
@@ -92,4 +92,16 @@ BaseRecordComponent::BaseRecordComponent() : Attributable(NoInit())
 
 BaseRecordComponent::BaseRecordComponent(NoInit) : Attributable(NoInit())
 {}
+
+void BaseRecordComponent::setDatasetDefined(
+    internal::BaseRecordComponentData &data)
+{
+    data.m_datasetDefined = true;
+}
+
+bool BaseRecordComponent::datasetDefined() const
+{
+    auto & data = get();
+    return data.m_datasetDefined;
+}
 } // namespace openPMD