Skip to content

Conversation

elshafei-developer
Copy link
Contributor

in Report Accounts Payable Summary

Before

Before

After

After

backport version-15-hotfix

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 8, 2025
Copy link

coderabbitai bot commented Sep 8, 2025

📝 Walkthrough

Walkthrough

  • accounts_receivable.py: In setup_ageing_columns, the label "Above" is now wrapped with the translation function _("Above").
  • accounts_receivable_summary.py: In AccountsReceivableSummary.get_columns, the "Total Amount Due" column label is wrapped with _("Total Amount Due").
  • No changes to control flow, data structures, computations, or exported/public interfaces.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ddc97df and 4c7a0a4.

📒 Files selected for processing (2)
  • erpnext/accounts/report/accounts_receivable/accounts_receivable.py (1 hunks)
  • erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.py (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: diptanilsaha
PR: frappe/erpnext#49373
File: erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts_accounts_receivable.html:86-96
Timestamp: 2025-08-29T12:08:57.357Z
Learning: In the Process Statement of Accounts accounts receivable template, the summary table that appears when show_future_payments is enabled correctly includes an "Age" column header that displays aggregate age metrics alongside the aging bucket totals. This alignment is intentional and should not be removed.
📚 Learning: 2025-08-29T12:08:57.357Z
Learnt from: diptanilsaha
PR: frappe/erpnext#49373
File: erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts_accounts_receivable.html:86-96
Timestamp: 2025-08-29T12:08:57.357Z
Learning: In the Process Statement of Accounts accounts receivable template, the summary table that appears when show_future_payments is enabled correctly includes an "Age" column header that displays aggregate age metrics alongside the aging bucket totals. This alignment is intentional and should not be removed.

Applied to files:

  • erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.py
  • erpnext/accounts/report/accounts_receivable/accounts_receivable.py
🧬 Code graph analysis (2)
erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.py (1)
erpnext/accounts/report/accounts_receivable/accounts_receivable.py (1)
  • add_column (1256-1266)
erpnext/accounts/report/accounts_receivable/accounts_receivable.py (1)
erpnext/setup/setup_wizard/operations/install_fixtures.py (1)
  • _ (20-25)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Python Unit Tests (3)
  • GitHub Check: Python Unit Tests (2)
  • GitHub Check: Python Unit Tests (4)
  • GitHub Check: Python Unit Tests (1)
  • GitHub Check: Patch Test
  • GitHub Check: Summary
🔇 Additional comments (3)
erpnext/accounts/report/accounts_receivable/accounts_receivable.py (1)

1271-1271: Good i18n fix: translate ageing bucket tail label.

Wrapping "Above" with _() ensures the last ageing bucket is translatable without affecting logic.

erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.py (2)

174-175: Good i18n fix: translate "Total Amount Due".

Label is now translatable; no behavior change.


174-175: No title mismatch or column change required
The PR title is “fix: add missing translation function,” not specific to Accounts Payable Summary, and accounts_payable_summary.py defines its columns differently (no add_column calls), so no mirroring is needed.

Likely an incorrect or invalid review comment.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant