Skip to content

fix: Incorrect filters in Voucher Child Table of Land Cost Voucher DocType #49500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2025
+12 −33
Merged

fix: Incorrect filters in Voucher Child Table of Land Cost Voucher DocType #49500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486507e
fix: company filter in receipt_document in landed cost voucher
anwarpatelnoori Sep 5, 2025
7978dfe
refactor: use strict equality
anwarpatelnoori Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 12 additions & 33 deletions erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,6 @@ frappe.provide("erpnext.stock");

erpnext.landed_cost_taxes_and_charges.setup_triggers("Landed Cost Voucher");
erpnext.stock.LandedCostVoucher = class LandedCostVoucher extends erpnext.stock.StockController {
setup() {
var me = this;
this.frm.fields_dict.purchase_receipts.grid.get_field("receipt_document").get_query = function (
doc,
cdt,
cdn
) {
var d = locals[cdt][cdn];

var filters = [
[d.receipt_document_type, "docstatus", "=", "1"],
[d.receipt_document_type, "company", "=", me.frm.doc.company],
];

if (d.receipt_document_type == "Purchase Invoice") {
filters.push(["Purchase Invoice", "update_stock", "=", "1"]);
}

if (!me.frm.doc.company) frappe.msgprint(__("Please enter company first"));
return {
filters: filters,
};
};
}

refresh() {
var help_content = `<br><br>
<table class="table table-bordered" style="background-color: var(--scrollbar-track-color);">
Expand Down Expand Up @@ -158,15 +133,19 @@ frappe.ui.form.on("Landed Cost Voucher", {
setup_queries(frm) {
frm.set_query("receipt_document", "purchase_receipts", (doc, cdt, cdn) => {
var d = locals[cdt][cdn];
if (d.receipt_document_type === "Stock Entry") {
return {
filters: {
docstatus: 1,
company: frm.doc.company,
purpose: ["in", ["Manufacture", "Repack"]],
},
};
var filters = [
[d.receipt_document_type, "docstatus", "=", "1"],
[d.receipt_document_type, "company", "=", frm.doc.company],
];

if (d.receipt_document_type == "Purchase Invoice") {
filters.push(["Purchase Invoice", "update_stock", "=", "1"]);
} else if (d.receipt_document_type === "Stock Entry") {
filters.push(["Stock Entry", "purpose", "in", ["Manufacture", "Repack"]]);
}
return {
filters: filters,
};
});

frm.set_query("vendor_invoice", "vendor_invoices", (doc, cdt, cdn) => {
Expand Down