refactor(meet): use plain textarea and gemoji instead of pulling editor#195
Merged
BreadGenie merged 3 commits intoJul 11, 2026
Merged
Conversation
…suggest Drop frappe-ui/editor from the meet chat composer so the meet chunk no longer pulls CommentKit/ProseMirror for plain-text input. Use a textarea with colon emoji autocomplete (gemoji) and align the people panel close button with chat.
Remember selected emojis and surface them first on empty `:` queries, padding with the default top matches so the menu always shows five items.
Drop the suite-unification dependency snapshot; package.json is the source of truth and nothing referenced the union file.
Contributor
Confidence Score: 5/5Safe to merge — the refactor is self-contained, well-tested, and removes a heavyweight dependency without changing the wire protocol. The emoji utility is fully unit-tested, edge cases (URL colon, empty query, recents dedup) are handled, and the textarea swap is straightforward. No data-loss or auth paths are touched. No files require special attention. Reviews (1): Last reviewed commit: "chore(frontend): remove obsolete package..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also remove the remnant package.union.json file from the suite migration