-
Notifications
You must be signed in to change notification settings - Fork 2
Added basic shooter subsystems with IO pattern #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yummy-yummers
wants to merge
3
commits into
main
Choose a base branch
from
lesson3-shooter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
tasks/lesson3-shooter-task/src/main/java/frc/robot/subsystems/shooter/Shooter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,55 @@ | ||
| package frc.robot.subsystems.shooter; | ||
|
|
||
| import edu.wpi.first.wpilibj.RobotBase; | ||
| import edu.wpi.first.wpilibj2.command.SubsystemBase; | ||
| import frc.robot.subsystems.shooter.ShooterIO.ShooterIOInputs; | ||
|
|
||
| // Main Shooter subsystem logic | ||
| public class Shooter extends SubsystemBase { | ||
| // TODO: Add a private field for your ShooterIO instance | ||
| private ShooterIO io; | ||
|
|
||
| // TODO: Add a private field for your ShooterIOInputs instance and initialize it | ||
| private ShooterIO.ShooterIOInputs inputs = new ShooterIO.ShooterIOInputs(); | ||
|
|
||
|
|
||
| // TODO: Create the constructor that takes a ShooterIO instance as a parameter | ||
| // public Shooter(ShooterIO io) { ... } | ||
| public Shooter(ShooterIO io) { | ||
| this.io = io; | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| public void periodic() { | ||
| // This method will be called once per scheduler run | ||
| // TODO: Call the updateInputs method on your ShooterIO instance | ||
| io.updateInputs(inputs); | ||
| if (!RobotBase.isReal()) { | ||
| if (true) { | ||
| spin(0.5); | ||
| } else { | ||
| stop(); | ||
| }} | ||
|
|
||
| System.out.println(inputs.motorRPM); | ||
| } | ||
|
|
||
| // TODO: Add a public method to spin the shooter motor at a given percentage output | ||
| // public void spin(double percent) { ... } | ||
| public void spin(double percent) { | ||
| io.setMotorPercentOutput(percent); | ||
| } | ||
|
|
||
| // TODO: Add a public method to stop the shooter motor | ||
| // public void stop() { ... } | ||
| public void stop() { | ||
| io.setMotorPercentOutput(0.0); | ||
| } | ||
|
|
||
| // TODO: Add a public method to return the current motor RPM | ||
| // public double getCurrentRPM() { ... } | ||
| public double getCurrentRPM() { | ||
| return inputs.motorRPM; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if trueis redundant