Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move react and react-dom to dev dependencies #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stackptr
Copy link
Member

react and react-dom are only needed to run Jest tests. Otherwise, react is expected to be provided from the existing peer dependency in consumer packages.

`react` and `react-dom` are only needed to run Jest tests. Otherwise, `react` is expected to be provided from the existing peer dependency in consumer packages.
@stackptr stackptr self-assigned this Nov 14, 2023
@stackptr stackptr marked this pull request as draft November 14, 2023 03:09
@stackptr
Copy link
Member Author

Before:

❯ yarn why react-dom -R
└─ @freckle/student-materials@workspace:.
   └─ @freckle/react-hooks@npm:5.2.0 [b78f6] (via npm:^5.2.0 [b78f6])
      └─ react-dom@npm:18.2.0 [e4050] (via npm:^18.2.0 [e4050])

After pointing to this branch, yarn why react-dom has no output.

@stackptr stackptr marked this pull request as ready for review November 14, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant