build: Fix an error that fails to find ls #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the path of "ls" can be platform dependent, it'd be better not to
specifiy its absolute path.
$ make
ldd: /usr/bin/ls: No such file or directory
g++ -Ilibleaktracer/include -Ilibleaktracer/src -DUSE_BACKTRACE ...
g++ -Ilibleaktracer/include -Ilibleaktracer/src -DUSE_BACKTRACE ...
...
This patch is to fix the error above.
hzeller
reviewed
Feb 1, 2020
| @@ -19,7 +19,7 @@ else | |||
| ifeq ($(CXX),) | |||
| CXX ?= g++ | |||
| endif | |||
| LIBDIR := $(shell echo -n lib; (ldd /usr/bin/ls |grep -q lib64) && echo -n 64) | |||
| LIBDIR := $(shell echo -n lib; (`which ls` | grep -q lib64) && echo -n 64) | |||
There was a problem hiding this comment.
You fixed the parameter, but removed the call to ldd here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the path of "ls" can be platform dependent, it'd be better not to
specifiy its absolute path.
This patch is to fix the error above.