Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pictures for exercise D - The Odin Project #204

Merged

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 4, 2023

Checklist:

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner May 4, 2023 12:41
@ojeytonwilliams
Copy link
Contributor

@Sembauke could you let us know where these are sourced from? Mostly so we can be sure there's no need for attribution.

@Sembauke
Copy link
Member Author

Sembauke commented May 4, 2023

@ojeytonwilliams
Copy link
Contributor

Thanks, unfortunately the issue is it's not clear how (or if) we can get the rights to use these. Maybe reach out to the photographers if you can't find the photos on the web?

@Sembauke
Copy link
Member Author

Sembauke commented May 4, 2023

Hey @ojeytonwilliams,

./pexels-katho-mutodo-8434791.jpg
./pexels-andrea-piacquadio-3777931.jpg

The images are from Pexels not Getty Images
https://www.pexels.com/ - it is a free image website

@naomi-lgbt
Copy link
Member

From their ToS:

5.7. Be aware that, depending on your intended use of the Content, you may need the permission or consent of a third party (e.g. owner of a brand, identifiable person or author/rights holder of copyrightable work depicted in the Content).

Not sure if these people count as identifiable, but are these specific images necessary? Could we replace them with something more generic?

@Sembauke
Copy link
Member Author

Sembauke commented May 5, 2023

Yes we could use some of our images, already present in the CDN.

@Sembauke Sembauke closed this May 5, 2023
@Sembauke Sembauke reopened this May 5, 2023
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look familiar!

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit a663f0c into freeCodeCamp:main May 5, 2023
@Sembauke Sembauke deleted the feat/add-pictures-exercise-D branch May 5, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants