Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add binary search tree asset #234

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

zairahira
Copy link
Member

Checklist:

Adding the asset for step-1 in the "Binary Search Tree" Python curriculum project.

@zairahira zairahira requested a review from a team as a code owner December 15, 2023 10:42
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we not name the folder upcoming-python. Maybe just python. At the end of the day, there is nothing specific to Python about this image.

Also, could someone confirm if we have a build step to reduce file size? Otherwise, we cannot go with a 77KB image.

@zairahira
Copy link
Member Author

I would prefer we not name the folder upcoming-python. Maybe just python. At the end of the day, there is nothing specific to Python about this image.

Also, could someone confirm if we have a build step to reduce file size? Otherwise, we cannot go with a 77KB image.

What's the recommended size?

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented Dec 15, 2023

@ShaunSHamilton yep, #218 is an example of it at work.

Also, the images should be cached, so learners will only have to download them once.

@ShaunSHamilton
Copy link
Member

What's the recommended size?

As low as possible to still use the image. The one Quincy liked as an example is 1KB.

@ojeytonwilliams
Copy link
Contributor

There are a few online image compression tools we can play with. https://tinypng.com/ seems okay, quality-wise, and got it down to 23.8kb.

Or we can just let the bot do it's thing and see how much it can save.

@zairahira
Copy link
Member Author

I have compressed the image to 16KB.

@ojeytonwilliams
Copy link
Contributor

That's much better - they look identical to me. Nice work, Zaira.

Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, instructional images should not contain text. Otherwise we can't translate the content.

Can we confirm that the instructions will identify, in text, all of the information conveyed here?

Also, the upcoming-python directory still needs to be removed.

@zairahira
Copy link
Member Author

Yes @naomi-lgbt, the instructions would cover the details mentioned in the image.

Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@ShaunSHamilton ShaunSHamilton merged commit ecbc0fc into freeCodeCamp:main Dec 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants