-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add binary search tree asset #234
feat: add binary search tree asset #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we not name the folder upcoming-python
. Maybe just python
. At the end of the day, there is nothing specific to Python about this image.
Also, could someone confirm if we have a build step to reduce file size? Otherwise, we cannot go with a 77KB image.
What's the recommended size? |
@ShaunSHamilton yep, #218 is an example of it at work. Also, the images should be cached, so learners will only have to download them once. |
As low as possible to still use the image. The one Quincy liked as an example is 1KB. |
There are a few online image compression tools we can play with. https://tinypng.com/ seems okay, quality-wise, and got it down to 23.8kb. Or we can just let the bot do it's thing and see how much it can save. |
I have compressed the image to 16KB. |
That's much better - they look identical to me. Nice work, Zaira. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, instructional images should not contain text. Otherwise we can't translate the content.
Can we confirm that the instructions will identify, in text, all of the information conveyed here?
Also, the upcoming-python
directory still needs to be removed.
Yes @naomi-lgbt, the instructions would cover the details mentioned in the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Checklist:
Update index.md
)Adding the asset for step-1 in the "Binary Search Tree" Python curriculum project.