Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The Odin Project pictures #238

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Sembauke
Copy link
Member

Checklist:

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner December 19, 2023 07:41
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, need to confirm that all of the instructional text content in these images is mirrored in the challenge texts for i18n purposes.

@Sembauke
Copy link
Member Author

Now how would we link the images for the different locales?

@naomi-lgbt
Copy link
Member

The images themselves can stay as they are, but the text content in the challenge needs to reflect all of the information in the image. For example, for this li'l guy I might include the following text in the challenge:

image

In the above image, the padding text points to the padding of the element, the border text points to the border of the element, and the margin text points to the margin of the element.

@Sembauke
Copy link
Member Author

Sembauke commented Dec 19, 2023

But what has that to do with these images? We can reflect on the description of these images in the main repo.
This is the CDN repo.

@naomi-lgbt
Copy link
Member

We can reflect on the description of these images in the main repo.

Yes, that is what I am asking. I want to make sure that is either already done, or in the works, so that it doesn't get forgotten about and become an i18n nightmare later. :3

@Sembauke
Copy link
Member Author

I was planning on doing this when updating the URLs 🙃

@naomi-lgbt naomi-lgbt merged commit 1a39df5 into freeCodeCamp:main Dec 19, 2023
1 check passed
@Sembauke Sembauke deleted the feat/odin-project-pictures branch December 19, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants