Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image for learn variables and operators The Odin Project #249

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Mar 1, 2024

Checklist:

Closes #XXXXX

@Sembauke Sembauke requested a review from a team as a code owner March 1, 2024 12:00
@ojeytonwilliams
Copy link
Contributor

Does this image need attribution or is this something you created?

@Sembauke
Copy link
Member Author

Sembauke commented Mar 1, 2024

What do you mean by "attribution" ?

@raisedadead
Copy link
Member

@Sembauke
Copy link
Member Author

Sembauke commented Mar 1, 2024

I am not sure, it is used in The Odin Project. But I don't think that's enough of a reason:
https://www.theodinproject.com/lessons/foundations-variables-and-operators

cc @raisedadead

@raisedadead
Copy link
Member

raisedadead commented Mar 1, 2024

Its a CC-BY-SA-4.0 CC BY-NC-SA 4.0, https://www.theodinproject.com/terms_of_use - you will need to add an attribution to the odin project (where the images is) as a caption, and mention that its a CC-BY-SA-4.0 CC BY-NC-SA 4.0

OR

Figure out not needing to the images.

Edit: Its CC BY-NC-SA 4.0

@Sembauke
Copy link
Member Author

Sembauke commented Mar 1, 2024

image Is this not enough? It's approved by The Odin team themselves. Adding anything to the image itself is absolute overkill.

https://creativecommons.org/licenses/by-nc-sa/4.0/

Share — copy and redistribute the material in any medium or format

@raisedadead
Copy link
Member

Is this not enough?

That is perfect.

@raisedadead raisedadead merged commit 88c9973 into main Mar 1, 2024
2 checks passed
@raisedadead raisedadead deleted the feat/top-learn-variables-and-operators branch March 1, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants