Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding JS music player tracks and imgs #256

Merged
merged 3 commits into from
May 8, 2024

Conversation

jdwilkin4
Copy link
Contributor

Summary

The music player project for the new JS curriculum is currently using assets served from S3. But they should come from our CDN instead.
This PR moves all of the tracks and images to the cdn repo

Checklist:

closes #255

@jdwilkin4 jdwilkin4 self-assigned this May 8, 2024
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner May 8, 2024 16:32
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I miss a discussion on this? Why do we need to move them to the CDN (which is also just an S3 bucket)?

@jdwilkin4
Copy link
Contributor Author

Oliver opened an issue here

freeCodeCamp/freeCodeCamp#54684

@naomi-lgbt naomi-lgbt merged commit f57eea1 into main May 8, 2024
1 check passed
@naomi-lgbt naomi-lgbt deleted the adding-music-player-tracks branch May 8, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Music player tracks and imgs
2 participants