fix: add missing MathJax resources, update path #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick review and merge :) |
This was referenced Jun 21, 2024
|
No worries, it looked good and easily reversible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Currently, if you visit a News article that's using MathJax served by the fCC CDN, there are a few 404s in the console due to missing resources:
This PR adds those missing resources, sourced from this repo, to the CDN, and updates the path slightly by moving everything into an
es5directory.Once these are added, I'll create a few more PRs to update News and the Hashnode preview service to use the script within the
es5directory, and test that all resources are fetched when the page loads.