Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

feat: limit number of events in the chapterCard #2127

Merged
merged 10 commits into from
Jan 8, 2023
Merged

feat: limit number of events in the chapterCard #2127

merged 10 commits into from
Jan 8, 2023

Conversation

Sboonny
Copy link
Member

@Sboonny Sboonny commented Dec 21, 2022

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Closes #2085

@ghost
Copy link

ghost commented Dec 21, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Sboonny Sboonny marked this pull request as ready for review January 4, 2023 09:35
@Sboonny Sboonny requested a review from a team January 4, 2023 09:35
@ojeytonwilliams
Copy link
Contributor

Since we're not showing all the events, could you change the text to be 'Next Events'? I think that's slightly more informative.

@gikf @ojeytonwilliams
fix chapter card text and order
5860ac0 
Co-authored-by: gikf <[email protected]>
Co-authored-by: Oliver Eyton-Williams <[email protected]>
@gikf gikf changed the title feat: filter events in the chapterCard feat: limit number of events in the chapterCard Jan 7, 2023
gikf
gikf approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@gikf gikf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sboonny Sboonny merged commit ad15ab8 into freeCodeCamp:main Jan 8, 2023
@Sboonny Sboonny deleted the feat/limit-the-events-in-chapterCard branch January 8, 2023 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gikf gikf gikf approved these changes

Assignees
No one assigned
Labels
API status: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display 3 events in chapterCard
3 participants
@Sboonny @ojeytonwilliams @gikf