fix(curriculum): replace D.O.B. acronym in accessibility quiz

[Supravisor]

Checklist:

• I have read and followed the contribution guidelines.
• I have read and followed the how to open a pull request guide.
• My pull request targets the main branch of freeCodeCamp.
• I have tested these changes either locally on my machine, or GitPod.

Related to #47830

[Supravisor]

Is it okay for this PR to proceed without further changes?

Then the should fix can be applied on Question 1 and Question 2 using the sr-only class, in a separate PR.
Otherwise another issue may need to merge into this one.

[bbsmooth]

Is it okay for this PR to proceed without further changes?

I would vote no.

"Although the Date of Birth text is descriptive, it can be problematic for visually impaired users."

This doesn't make sense. Date of Birth is not problematic for visually impaired users. Also, you wouldn't add visually hidden text that is exactly the same as the visible text. That's just unnecessary duplication for screen reader users.

It's not just a matter of changing D.O.B to Date of Birth. This entire step needs to be reworked.

[Supravisor]

Is it okay for this PR to proceed without further changes?

Then the should fix can be applied on Question 1 and Question 2 using the sr-only class, in a separate PR. Otherwise another issue may need to merge into this one.

Is it okay for this PR to proceed without further changes?

I would vote no.

"Although the Date of Birth text is descriptive, it can be problematic for visually impaired users."

This doesn't make sense. Date of Birth is not problematic for visually impaired users. Also, you wouldn't add visually hidden text that is exactly the same as the visible text. That's just unnecessary duplication for screen reader users.

It's not just a matter of changing D.O.B to Date of Birth. This entire step needs to be reworked.

My question was "Is it okay for this PR to proceed without further changes?" - MUST FIX No 4. This way another PR can be made to add sr-only class for Question 1 and Question 2 - Should fix No 1.

naomi-lgbt requested that separate PRs are created to address ten identified issues.

Although several steps may require multiple rework, a way forward without merging one or more PRs looks tenuous.

Note: this PR already has one approval.

If this PR receives a second review approval, a pathway forward is outlined as follows:

1. MUST FIX No.3: The Question 1 and Question 2 text look like headings and should probably be marked up as headings.
2. Should Fix No. 1: "Question 1" and "Question 2" sr-only text be added to the beginning of their respective questions so that screen reader users navigating by tab stop will hear the question number as well as the question text.

[bbsmooth]

My question was "Is it okay for this PR to proceed without further changes?"

And my answer is that it doesn't make sense to merge this PR as it is without further changes because it is wrong.

"Although the Date of Birth text is descriptive, it can be problematic for visually impaired users. One way to get around such an issue is to add text only a screen reader can read."

This is just wrong. "Date of Birth" is not problematic for blind people. You would not add text that only a screen reader can read. If you ask me, the changes in this PR make this step worse and I'd rather leave the step as it is now.

[naomi-lgbt]

naomi-lgbt requested that separate PRs are created to address ten identified issues.

Yes, but if the changes don't make sense to separate, then this doesn't apply.

In this case, it seems like we need to resolve multiple things at once.

• Instead of using D.O.B. for the label, use Date of Birth
• Change the screen reader text steps to apply Question 1 and Question 2 to the labels

[ojeytonwilliams]

Hey @Supravisor any thought on Naomi's comments?

[Supravisor]

I'll start on the suggestions in the next few days.