fix: error at color-system story#378
Conversation
huyenltnguyen
left a comment
There was a problem hiding this comment.
Thank you for the PR.
There are a couple of issues with the changes that I don't think we can merge as-is:
colors.cssstill exists, and its import aren't updated.- We are using globally-scoped stylesheets in the codebase, if we are changing this to a module, other stylesheets should follow.
- We would like to understand the root cause of the issue (whether this is an issue in the repo setup or in the storybook setup) in order to update the config accordingly.
i have impression that problem is not the storybook, |
|
is the PR is blocked? |
Yes. The changes haven't addressed my concerns in #378 (review). |
|
Thank you for opening this pull request. This is a standard message notifying you that we've reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you. Thank you and happy coding. |
not sure why, but things start working after renaming
color.csstocolors.module.css:Update index.md)Closes #66