Redirect badge spam and more results not working. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ManagarmrWhisperer
commented
Jan 13, 2024
•
ManagarmrWhisperer
commented
- Verify functionality
alex4401
requested changes
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
| @@ -171,15 +171,15 @@ const rewrite = { | |||
|
|
|||
|
|
|||
| run( wiki, linkElement ) { | |||
| if ( linkElement !== null && !this.isLocked( linkElement ) ) { | |||
| if ( linkElement !== null ) { | |||
| // Find result container | |||
| const element = linkElement.closest( 'article' ); | |||
|
|
|||
| const isTopLevel = a => { | |||
There was a problem hiding this comment.
Since we're here, have another commit address this being a closure that's later being passed 'as' a bool. There's no reason for this to be a closure.
alex4401
reviewed
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
alex4401
reviewed
Jan 13, 2024
ManagarmrWhisperer
force-pushed
the
hotfix/ddg-redirect-bug
branch
from
f8e2c45
to
7815c45
Compare
ManagarmrWhisperer
force-pushed
the
hotfix/ddg-redirect-bug
branch
from
7815c45
to
9e56525
Compare
|
Cherry-picked the redirect badge fix into master (04dd427). I'll need to take a look later at the more results patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.