Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Intel NUC13 to the recommended hardware list; deprecate NUC10 #542

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

nathandyer
Copy link
Contributor

Status

Ready for review (although @zenmonkeykstop may prefer to hold off on merging until he is able to test the system as well)

Description of Changes

  • Description: This PR adds the Intel NUC13 to the recommended hardware list, including the hardware end-of-life table, and provides an updated photo showing the wireless card removal.

  • Related Issues
    Research alternatives to NUC server hardware #480

Testing

  • Visual review
  • CI passes

Release

  • Can be merged and tagged in a stable release at any point (does not need to coincide with a server release)

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

.. _nucc12_recommendation:
.. _nuc13_recommendation:

Intel 13th-gen NUC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this the "ASUS 13th-gen NUC" since that's what the product page says? And then I suppose a small comment explaining that Intel transitioned NUCs to ASUS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, you removed "Intel" from everywhere in #540 so seems like the answer is yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @legoktm! It looks like 8c5d701 took care of the name switch, and then I just tacked on 55568e2 which should cover off the explanation about the transition to ASUS. Please let me know what you think.

docs/admin/installation/hardware.rst Show resolved Hide resolved
@legoktm
Copy link
Member

legoktm commented Mar 13, 2024

I'll pick this up after #540 lands to avoid conflicting.

zenmonkeykstop
zenmonkeykstop previously approved these changes Apr 26, 2024
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed conflicts, approving pending CI run.

@zenmonkeykstop zenmonkeykstop added this pull request to the merge queue Apr 26, 2024
@legoktm legoktm removed this pull request from the merge queue due to a manual request Apr 26, 2024
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong in the rebase, a number of changes in the previous PR are being overwritten here.

docs/admin/installation/hardware.rst Show resolved Hide resolved
docs/admin/installation/hardware.rst Show resolved Hide resolved
docs/admin/installation/hardware.rst Outdated Show resolved Hide resolved
docs/admin/installation/hardware.rst Outdated Show resolved Hide resolved
docs/admin/installation/hardware.rst Outdated Show resolved Hide resolved
docs/admin/installation/hardware.rst Outdated Show resolved Hide resolved
@eloquence eloquence self-assigned this Aug 22, 2024
nathandyer and others added 3 commits August 22, 2024 09:50
This commit adds the Intel NUC13 to the recommended hardware list,
including the hardware end-of-life table. Because the NUC13 uses
the same wireless card as the NUC12, and is very similar in its
hardware apart from the CPU, much of the content is borrowed from
the NUC12 section.
@eloquence eloquence changed the title Add the Intel NUC13 to the recommended hardware list Add the Intel NUC13 to the recommended hardware list; deprecate NUC10 Aug 22, 2024
@eloquence
Copy link
Member

This should be ready for another review pass. Thanks Nathan for all the work on this.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@legoktm legoktm added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 693cfea Aug 28, 2024
4 checks passed
@legoktm legoktm deleted the nuc13 branch August 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants