-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Intel NUC13 to the recommended hardware list; deprecate NUC10 #542
Conversation
docs/admin/installation/hardware.rst
Outdated
.. _nucc12_recommendation: | ||
.. _nuc13_recommendation: | ||
|
||
Intel 13th-gen NUC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this the "ASUS 13th-gen NUC" since that's what the product page says? And then I suppose a small comment explaining that Intel transitioned NUCs to ASUS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, you removed "Intel" from everywhere in #540 so seems like the answer is yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pick this up after #540 lands to avoid conflicting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed conflicts, approving pending CI run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something went wrong in the rebase, a number of changes in the previous PR are being overwritten here.
This commit adds the Intel NUC13 to the recommended hardware list, including the hardware end-of-life table. Because the NUC13 uses the same wireless card as the NUC12, and is very similar in its hardware apart from the CPU, much of the content is borrowed from the NUC12 section.
This should be ready for another review pass. Thanks Nathan for all the work on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Status
Ready for review (although @zenmonkeykstop may prefer to hold off on merging until he is able to test the system as well)
Description of Changes
Description: This PR adds the Intel NUC13 to the recommended hardware list, including the hardware end-of-life table, and provides an updated photo showing the wireless card removal.
Related Issues
Research alternatives to NUC server hardware #480
Testing
Release
Checklist (Optional)
make docs-lint
) passed locallymake docs-linkcheck
) passedmake docs
) docs at http://localhost:8000