Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journalist UI change 6904 #7176

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rjbaarsma
Copy link

Status

Ready for review

Description of Changes

Fixes #6904.

Changes proposed in this pull request:

  • The journalist Scripting has changed to disable buttons above the source rows as long as none of the rows are selected
  • The journalist css has been changed to grey out disabled buttons,

Testing

I've not added unit tests for this change. Testing plan

  • Build using make dev
  • Log in as "journalist"
  • The buttons above the source list (except for Select All and Select None) should be disabled, as no rows are selected
  • Selecting any row will enable the buttons
  • Buttons should always be enabled while any row is selected
  • Using the Select All or Select None buttons should also affect the availability of the buttons

Checklist

  • These changes do not require documentation

@rjbaarsma rjbaarsma requested a review from a team as a code owner June 7, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Journalist Interface: in "All Sources" listing, hide source-level actions when none are selected
1 participant