fix(ai): coerce query_workspace limit to int (str limit crashed the backend)#1280
Merged
Conversation
… backend)
Some models send the `limit` arg as a string ("10"); a str limit reached the
query backend and raised `TypeError: '>=' not supported between instances of int
and str` (json.py: `len(matched) >= limit`). Coerce `limit` to int in
_handle_query, falling back to the default (100) for bad/None values. Same class
as the stringified-arg coercion (#1275), which only handles object/array params.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NNjPggRSVZ2xnLb7ZxWP5H
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The model sent
query_workspace'slimitas a string ("10"); it reached the backend and broke the>=comparison. Same "model stringifies args" class as #1275, butcoerce_stringified_argsonly handles object/array params — not scalar ints likelimit.Fix
Coerce
limittointin_handle_query; bad/None values fall back to the default (100).Tests
Stringified
"10"→10reaches the backend; a non-numeric limit falls back to 100.test_ai_actions.py99 passed; the original crash reproduces as resolved.Targets
ai-resiliency(#1241).🤖 Generated with Claude Code