Read failure retries - #15
Conversation
Co-authored-by: Nico Tonozzi <nico@nicot.us>
Co-authored-by: Nico Tonozzi <nico@nicot.us>
|
Cursor Agent can help with this pull request. Just |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a changelog entry and bumps package version to 0.5.9; updates HTTP retry policy to include read retries (read=3) and restrict retries to GET requests. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Co-authored-by: Nico Tonozzi <nico@nicot.us>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/freeplay/api_support.py`:
- Line 14: The file's formatting doesn't match ruff's expected style for the
_retry assignment; run ruff format on src/freeplay/api_support.py (or make
lint-check) and reformat the line that defines _retry (the Retry(...)
assignment) so it matches ruff/PEP8 style (adjust spacing, quotes, and line
breaks as ruff dictates) and then commit the formatted file.
Co-authored-by: Nico Tonozzi <nico@nicot.us>
Enable retries on read failures to improve API call robustness.
Note
Add up to 3 read-failure retries for GET requests in
freeplay.api_support._retryand document the changeExpand the
Retryconfig to includeread=3and restrictallowed_methodsto{"GET"}in api_support.py; bump version to 0.5.9 and update changelog.📍Where to Start
Start with the
_retryconfiguration and session mounting in api_support.py.Changes since #15 opened
_retryvariable initialization in theapi_supportmodule [96fd283]Macroscope summarized f8fd8b3.
Summary by CodeRabbit
Bug Fixes
Chores