Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Soroban devcontainer #118

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Update the Soroban devcontainer #118

merged 4 commits into from
Sep 2, 2024

Conversation

thpani
Copy link
Collaborator

@thpani thpani commented Sep 2, 2024

Update to latest stellar-cli (replaces soroban-cli).

Remove soroban network add, since stellar-cli now comes pre-configured with networks local, testnet, futurenet, mainnet.

Generate keys for alice and bob directly in the Dockerfile.

`dev-bookworm` is needed for `rustc` 1.79.0
stellar-cli now comes pre-configured with networks `local`, `testnet`, `futurenet`, `mainnet` and keys for accounts `alice` and `bob`.
@thpani thpani requested a review from konnov September 2, 2024 12:33
Copy link
Contributor

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thpani thpani merged commit 703e355 into main Sep 2, 2024
3 checks passed
@thpani thpani deleted the th/soroban-devcontainer branch September 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants