Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage loading #132

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix storage loading #132

merged 2 commits into from
Oct 17, 2024

Commits on Oct 8, 2024

  1. Fix type annotation

    @thpani
    thpani committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1cecfcb View commit details
    Browse the repository at this point in the history

  2. Fix loading storage 

    Immutable.fromJS deeply converts all JS objects to Maps.
For deserializing storage, we want the target object to instead be
Map -> JS object {instance:, persistent:, temporary:} -> Map.
Thus, we provide a custom loader instead.
    @thpani
    thpani committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    249b0ed View commit details
    Browse the repository at this point in the history