Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play on XBMC" no longer shows up in apps that used to support it #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"Play on XBMC" no longer shows up in apps that used to support it #44

wants to merge 1 commit into from

Conversation

ackalker
Copy link

On recent build, apps that launch a video player no longer show "Play on XBMC" as an option in their pop-up menus.

Some looking around shows this is related to changes to the intent-filters in AndroidManifest.xml .
I don't know exactly why, but reverting part of commit 503c1d2 's changes to AndroidManifest.xml resolves the problem, the apps show "Play on XBMC" in their pop-up menus again.

A few affected apps:

  • Gemist! (Dutch app)
  • TVGids.nl 2.0 (Dutch app)

There are probably more. YouTube is not affected.

…art a video player

Partially revert commit 503c1d2,
wrt input-filters in AndroidManifest.xml .
This makes "Play on XBMC" show up again in the pop-up menu which gets displayed when
selecting a video player.

Signed-off-by: Alain Kalker <[email protected]>
@ackalker
Copy link
Author

One humble request too @freezy : Please keep unrelated changes in separate commits.
I had to git log -p -- AndroidManifest.xml to track down in which commit the changes were made, then had to use git checkout -p <commit> -- AndroidManifest.xml to select the patch hunks to be retained.

@freezy
Copy link
Owner

freezy commented Sep 10, 2012

Okay, will do my best.

@ackalker
Copy link
Author

Thanks for quick reply :-)

bitgangsta added a commit to bitgangsta/android-xbmcremote that referenced this pull request Sep 23, 2012
Pull request freezy#44, fixes issue: "Play on XBMC" no longer shows up in apps that used to support it
bitgangsta added a commit to bitgangsta/android-xbmcremote that referenced this pull request Sep 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants