Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to meet the code of conduct #891

Closed
wants to merge 1 commit into from
Closed

Conversation

brimmasch
Copy link

@brimmasch brimmasch commented Jan 23, 2025

The code of conduct states no sexualized language should be used. The code of conduct also places an emphasis and focus on safety and inclusivity. I would assume that this safety and inclusivity should extend to all ages and all people. This means that the documentation should be safe for all ages.

For reference:
https://github.com/frenck/spook/blob/main/.github/CODE_OF_CONDUCT.md

I removed the word "fucking"

Description

In the documentation/index.md file I removed the word "fucking" so that this change would reflect on the main page of https://spook.boo/

Motivation and Context

This repository and project should be for all ages and all walks of life. For all people. This language is not for all people.

How has this been tested?

I used VS Code to view the markup.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

The code of conduct states no sexualized language should be used.  This needs to be professional and safe for work and all ages.  This language is not necessary.

https://github.com/frenck/spook/blob/main/.github/CODE_OF_CONDUCT.md
Copy link

coderabbitai bot commented Jan 23, 2025

📝 Walkthrough

Walkthrough

The pull request involves a minor text modification in the documentation/index.md file for the Spook project. Specifically, the phrase "Absofuckinglutely!" has been replaced with "Absolutely!", adjusting the tone of the documentation while maintaining the overall content structure and meaning.

Changes

File Change Summary
documentation/index.md Replaced profane phrase with a more professional alternative

Suggested labels

documentation

Suggested reviewers

  • frenck

Possibly related PRs

Poem

🐰 A rabbit's documentation tale,
Where words once wild now set sail,
From spicy language to pure delight,
A gentle edit makes it just right!
Professionalism wins the day! 📝


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
documentation/index.md (1)

21-21: Consider improving sentence structure.

The current sentence structure could be simplified for better readability.

Consider this revision:

-If you would ever ask me, if you should use Spook? I would say: Absolutely! (But, I might be biased 😉)
+Should you use Spook? Absolutely! (But I might be biased 😉)
🧰 Tools
🪛 LanguageTool

[uncategorized] ~21-~21: If “ if” starts an indirect question, you do not need to put a comma before it.
Context: ...istant itself. If you would ever ask me, if you should use Spook? I would say: Abso...

(NO_COMMA_BEFORE_INDIRECT_QUESTION)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d2a36d and d6d9407.

📒 Files selected for processing (1)
  • documentation/index.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
documentation/index.md

[uncategorized] ~21-~21: If “ if” starts an indirect question, you do not need to put a comma before it.
Context: ...istant itself. If you would ever ask me, if you should use Spook? I would say: Abso...

(NO_COMMA_BEFORE_INDIRECT_QUESTION)

🔇 Additional comments (1)
documentation/index.md (1)

21-21: Content change aligns with code of conduct.

The replacement of inappropriate language with "Absolutely!" maintains the enthusiastic tone while making the documentation more inclusive and appropriate for all audiences.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~21-~21: If “ if” starts an indirect question, you do not need to put a comma before it.
Context: ...istant itself. If you would ever ask me, if you should use Spook? I would say: Abso...

(NO_COMMA_BEFORE_INDIRECT_QUESTION)

@brimmasch brimmasch marked this pull request as draft January 23, 2025 21:06
@brimmasch
Copy link
Author

I am not able to add labels to fix the approval workflow. Can somebody point me to documentation to fix this?

@brimmasch brimmasch marked this pull request as ready for review January 23, 2025 21:07
@frenck
Copy link
Owner

frenck commented Jan 23, 2025

Hehe sorry, but I am going to friendly decline.

Spook is designed to be the rebel.

../Frenck

@frenck frenck closed this Jan 23, 2025
@brimmasch
Copy link
Author

seriously? so anybody can just act how and say whatever they want as long as they say they're designed to be the rebel? seems... unjustifiable. what's the point of the code of conduct then?

@frenck
Copy link
Owner

frenck commented Jan 27, 2025

I can, this is my repo. Like it or not.

Dude... chill... drink a beer a bit more and enjoy life instead of getting on top this stuff. This repo is less serious, Spook is a little rebbel, there are more bad words to be found.

Chill.

@brimmasch
Copy link
Author

implying that i don't enjoy life? or that i need to "chill"? that's borderline a personal attack. i can care about what i care about and if it's not the same things that you care about, i don't need to "chill." let's keep this constructive.

demonstrating empathy and kindness toward other people would include not using offensive language. being respectful of differing opinions, viewpoints and experiences would include using all inclusive language. gracefully accepting constructive feedback would be taking this change as it is clearly against the repository's code of conduct. focusing on what is best not just for you as an individual but for the overall community also comes into play. in many parts of the world this type of language is not common or representative of the people. this language is sexualized. the word, in fact, literally means the act of forcefully having sex. it is not appropriate in some professional settings. it is not appropriate in some academic settings. the language is at odds with many religious organizations and personal and beliefs. for those groups, this language can be offensive, alienating and exclusionary.

if you follow and believe in your code of conduct, there is literally no reason for you to not remove that word. you can get similar emphasis using other language/words. why is this even a discussion? this seemed so obvious.

i'm not going after contribution. don't accept the pr. it's just not needed to be so offensive.

if you intend for this repo to be less serious then modify the code of conduct or drop it. right now you are not being inclusive or respectful to various groups of people to use language like that and are not following the code of conduct.

@frenck
Copy link
Owner

frenck commented Jan 28, 2025

that's borderline a personal attack.

Stopped reading there.
Bye! 👋

@brimmasch
Copy link
Author

Stopped reading there. Bye! 👋

very respectful. right on cue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants