Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch missing shorthands for border-[inline|block]-* properties #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jesstelford
Copy link

As per the CSS Logical spec, border-block-color, border-block-style, border-block-width, border-inline-color, border-inline-style and border-inline-width are all shorthand properties.

However, they're currently showing up in the StandardLonghandProperties type which is incorrect:

export interface StandardLonghandProperties<TLength = (string & {}) | 0, TTime = string & {}> {
  // ...
  borderBlockColor?: Property.BorderBlockColor | undefined;
  // ...
}

This PR aims to patch in the missing data so they are moved to the StandardShorthandProperties type.

As per [the CSS Logical spec](https://drafts.csswg.org/css-logical), `border-block-color`, `border-block-style`, `border-block-width`, `border-inline-color`, `border-inline-style` and `border-inline-width` are all shorthand properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant